Skip to content

Commit f0c466f

Browse files
authored
fix: add additional severity field to stackdriver (#194)
1 parent 3e17d6d commit f0c466f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sloggers/slogstackdriver/slogstackdriver.go

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ func (s stackdriverSink) LogEntry(ctx context.Context, ent slog.SinkEntry) {
5656
// https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/configuration#special-fields
5757
e := slog.M(
5858
slog.F("logging.googleapis.com/severity", sev(ent.Level)),
59+
slog.F("severity", sev(ent.Level)),
5960
slog.F("message", ent.Message),
6061
// Unfortunately, both of these fields are required.
6162
slog.F("timestampSeconds", ent.Time.Unix()),

sloggers/slogstackdriver/slogstackdriver_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func TestStackdriver(t *testing.T) {
4343

4444
j := entryjson.Filter(b.String(), "timestampSeconds")
4545
j = entryjson.Filter(j, "timestampNanos")
46-
exp := fmt.Sprintf(`{"logging.googleapis.com/severity":"ERROR","message":"line1\n\nline2","logging.googleapis.com/sourceLocation":{"file":"%v","line":40,"function":"cdr.dev/slog/sloggers/slogstackdriver_test.TestStackdriver"},"logging.googleapis.com/operation":{"producer":"meow"},"logging.googleapis.com/trace":"projects/%v/traces/%v","logging.googleapis.com/spanId":"%v","logging.googleapis.com/trace_sampled":%v,"wowow":"me\nyou"}
46+
exp := fmt.Sprintf(`{"logging.googleapis.com/severity":"ERROR","severity":"ERROR","message":"line1\n\nline2","logging.googleapis.com/sourceLocation":{"file":"%v","line":40,"function":"cdr.dev/slog/sloggers/slogstackdriver_test.TestStackdriver"},"logging.googleapis.com/operation":{"producer":"meow"},"logging.googleapis.com/trace":"projects/%v/traces/%v","logging.googleapis.com/spanId":"%v","logging.googleapis.com/trace_sampled":%v,"wowow":"me\nyou"}
4747
`, slogstackdriverTestFile, projectID, span.SpanContext().TraceID(), span.SpanContext().SpanID(), span.SpanContext().IsSampled())
4848
assert.Equal(t, "entry", exp, j)
4949
}

0 commit comments

Comments
 (0)