Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] User 관련 API 구현 #15

Open
DOEKYONG opened this issue Jul 31, 2023 · 0 comments · Fixed by #19, #20 or #23
Open

[BE] User 관련 API 구현 #15

DOEKYONG opened this issue Jul 31, 2023 · 0 comments · Fixed by #19, #20 or #23
Assignees
@chunghye98 @DOEKYONG @swinb
Labels
💻 BE 백엔드 관련 작업 ✨ feat 새로운 기능 구현
Milestone
[BE] 2주차 스프린트

Comments

@DOEKYONG
Copy link

DOEKYONG commented Jul 31, 2023 •
edited by chunghye98
Loading

AS-IS

회원가입, jwt 로그인, access token 재발급, OAuth, 로그아웃 불가

TO-BE

회원가입, jwt 로그인 , access token 재발급, OAuth, 로그아웃 가능
@DOEKYONG DOEKYONG added ✨ feat 새로운 기능 구현 💻 BE 백엔드 관련 작업 labels Jul 31, 2023
@DOEKYONG DOEKYONG added this to the [BE] 2주차 스프린트 milestone Jul 31, 2023
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Jul 31, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : 회원가입 구현
e720755
@chunghye98 chunghye98 changed the title [be] 회원가입, jwt 로그인 , OAuth [BE] 회원가입, jwt 로그인 , OAuth Jul 31, 2023
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 1, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : 회원가입 레포지토리 테스트 구현
dde0295
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 fix : ErrorCode 추가 및 응답코드 수정
2318200
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : 회원가입 이메일 중복 체크 , 로그인 구현
e9b489d
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 chore : 패키지 이동
197b46f
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : jwt accessToken, refreshToken 생성
c7993aa
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : 로그인 성공시 jwt 토큰 발급
f054232
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : 엑세스토큰 만료시 엑세스토큰 재요청 api
55fb596
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 feat : jwt filter 구현
067bdea
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 test : UserRepositoryTest 부분 구현
6e1c6d9 
- 회원가입
- 유저 찾기
- 리프레시 토큰 찾기 , 저장, 업데이트
DOEKYONG added a commit to DOEKYONG/issue-tracker-max that referenced this issue Aug 2, 2023
@DOEKYONG
codesquad-issue-team-05#15 test : UserServiceTest 부분 구현
89ddf27 
- 로그인
@chunghye98 chunghye98 changed the title [BE] 회원가입, jwt 로그인 , OAuth [BE] 회원가입, jwt 로그인, access token 재발급 Aug 2, 2023
@DOEKYONG DOEKYONG linked a pull request Aug 2, 2023 that will close this issue
[BE] 회원가입, jwt 로그인 기능 구현 #19
Merged
DOEKYONG added a commit that referenced this issue Aug 2, 2023
@DOEKYONG
Merge pull request #19 from DOEKYONG/dev-be/feature/#15
8f2402d 
Dev be/feature/#15
@chunghye98 chunghye98 changed the title [BE] 회원가입, jwt 로그인, access token 재발급 [BE] 회원가입, jwt 로그인, access token 재발급, OAuth Aug 2, 2023
@chunghye98 chunghye98 changed the title [BE] 회원가입, jwt 로그인, access token 재발급, OAuth [BE] User 관련 API 구현 Aug 2, 2023
chunghye98 added a commit that referenced this issue Aug 2, 2023
@chunghye98
#15 feat: 로그아웃 구현
ca47ae2
@chunghye98 chunghye98 linked a pull request Aug 2, 2023 that will close this issue
[BE] 로그아웃 API 구현 #20
Merged
DOEKYONG added a commit that referenced this issue Aug 3, 2023
@DOEKYONG
Merge pull request #20 from codesquad-issue-team-05/dev-be/feature/#15
ab611ed 
[BE] 로그아웃 API 구현
chunghye98 added a commit that referenced this issue Aug 3, 2023
@chunghye98
#15 chore: 패키지명 변경(service -> util)
7bf70db
chunghye98 added a commit that referenced this issue Aug 3, 2023
@chunghye98
#15 feat: oauth login 구현
87c64ee
chunghye98 added a commit that referenced this issue Aug 3, 2023
@chunghye98
#15 chore: oauth login 의존성 추가
ae4e563
chunghye98 added a commit that referenced this issue Aug 3, 2023
@chunghye98
#15 refactor: user insert 시 default image 들어가도록 수정
ab11265
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 chore : 패키지 이동
ea21f3c
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 feat : jwt accessToken, refreshToken 생성
a7f5fa5
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 feat : 로그인 성공시 jwt 토큰 발급
1fa19c1
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 feat : 엑세스토큰 만료시 엑세스토큰 재요청 api
8313399
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 feat : jwt filter 구현
c746af1
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 test : UserRepositoryTest 부분 구현
9565fa1 
- 회원가입
- 유저 찾기
- 리프레시 토큰 찾기 , 저장, 업데이트
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 test : UserServiceTest 부분 구현
611e9d1 
- 로그인
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 feat: 로그아웃 구현
5b78052
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 chore: 패키지명 변경(service -> util)
001c756
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 feat: oauth login 구현
3687137
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 chore: oauth login 의존성 추가
41cd97d
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 refactor: user insert 시 default image 들어가도록 수정
8beda08
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@chunghye98 @saejinpark
#15 refactor: 로그인 요청 시 조건 추가
e011262
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 refactor : OAuth 에서 가져오는 정보 name -> 로그인 한 아이디로 변경
478ba4b 
깃허브에서 name 을 설정하지 않는 사용자면 null 값이 담기게 되어서 변경
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 refactor : 로컬로그인 사용 시 깃허브 사용자는 로그인 할 수 없도록 리팩토링
db36d8a 
- 토큰 insert or update 부분 조건문에서 메서드로 분리
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 fix : 깃허브 이메일이 null 이어서 회원가입이 되지 않는 문제 수정
8e08961 
- 깃허브 이메일이 public 상태가 아니면 https://api.github.com/user 에서 email 정보를 받아오지 못하여서 email을 저장하지 못하고 email 을 사용하는 부분에서 오류 발생

- https://api.github.com/user/emails 로 따로 요청을 하면 public 상태가 아니어도 사용자의 이메일을 가져올 수 있음
saejinpark pushed a commit that referenced this issue Aug 7, 2023
@DOEKYONG @saejinpark
#15 refactor : 로그인 정책 변경으로 인한 로직 수정 및 리팩토링
1af612e 
- 자체 회원가입 한 유저의 이메일이 깃허브 로그인 이메일과 같을 때 해당 유저의 정보를 깃허브 정보로 갱신 하려 했으나 로그인을 하면서 회원정보를 갱신하는 것은 로그인이 너무 많은 일을 하게 되는 것 같아서
깃허브로 로그인/회원가입 한 유저는 자체 로그인을 이용하지 못하게 변경
@swinb swinb pinned this issue Aug 8, 2023
@swinb swinb unpinned this issue Aug 8, 2023
swinb added a commit to swinb/issue-tracker-max that referenced this issue Aug 8, 2023
@swinb
codesquad-issue-team-05#15 refactor : 로그인 타입도 entity 에서 검증하도록 변경
caccc92
swinb added a commit to swinb/issue-tracker-max that referenced this issue Aug 8, 2023
@swinb
codesquad-issue-team-05#15 refactor : enum 타입 비교 시 등호 -> equals 로 변경
a3ca401
swinb added a commit to swinb/issue-tracker-max that referenced this issue Aug 8, 2023
@swinb
codesquad-issue-team-05#15 test : 유저 서비스 로그인 기능 테스트 구현
2d880ee
swinb added a commit that referenced this issue Aug 8, 2023
@swinb
#15 refactor : 로그인 타입도 entity 에서 검증하도록 변경
d6b9855
swinb added a commit that referenced this issue Aug 8, 2023
@swinb
#15 refactor : enum 타입 비교 시 등호 -> equals 로 변경
56439ae
swinb added a commit that referenced this issue Aug 8, 2023
@swinb
#15 test : 유저 서비스 로그인 기능 테스트 구현
beff0e7
swinb added a commit that referenced this issue Aug 9, 2023
@swinb
#15 chore : 유저 name 길이 제한 변경
bf09c13
swinb added a commit that referenced this issue Aug 9, 2023
@swinb
#15 refactor : reissue 요청 시 반환 타입 변경
31c4fa0
swinb added a commit that referenced this issue Aug 9, 2023
@swinb
Merge pull request #45 from codesquad-issue-team-05/dev-be/feature/#15
6c7780a 
Dev be/feature/#15
swinb added a commit that referenced this issue Aug 9, 2023
@swinb
Merge pull request #46 from codesquad-issue-team-05/revert-45-dev-be/…
2691552 
…feature/#15

[BE] userService 테스트 구현 및 리팩토링
swinb added a commit that referenced this issue Aug 9, 2023
@swinb
#15 feat : ResponseAccessToken 추가
8343175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chunghye98 chunghye98

@DOEKYONG DOEKYONG

@swinb swinb

Labels
💻 BE 백엔드 관련 작업 ✨ feat 새로운 기능 구현
Projects
None yet
Milestone
[BE] 2주차 스프린트
3 participants
@chunghye98 @DOEKYONG @swinb