Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is directus necessary as a dependency? #9

Open
aurelsziebert opened this issue Jun 15, 2023 · 1 comment
Open

Is directus necessary as a dependency? #9

aurelsziebert opened this issue Jun 15, 2023 · 1 comment
Assignees

Comments

@aurelsziebert
Copy link

aurelsziebert commented Jun 15, 2023

The directus package is installed as a dependency, but I am not sure why. As I ran over the source code I saw imports only from @directus/shared package what can be installed separately - it is not necessary to install the whole ecosystem for this subpackage. In my opinion, this practice is problematic on conceptual level anyway, because it is an extension of a system, so it shouldn't contain the whole system again.

Actually it cases a problem for us, because we use an own forked version of Directus API, and Directus App, but the original versions of these packages come with this extension, and these original codes start to work on startup instead of our forked versions.

Is it possible to uninstall directus, and install @directus/shared package directly instead?

@codihaus
Copy link
Owner

I'm not sure if I fully understand your concern, but we don't install the full Directus package. We only install the packages that we need, like @directus/composables, @directus/constants, etc. Could you provide a screenshot or some other way to show us where changes might be needed? We'll review and consider making adjustments.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants