Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --push option from the collect command #67

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

mikberg
Copy link
Contributor

@mikberg mikberg commented Mar 11, 2022

The option to make the collect command push the snapshot to remote
storage isn't used, and make our API more confusing. Let's remove it,
at least for now.

Breaking Changes

The --push option to the collect command is no longer available. Instead, run the push command after collecting a snapshot.

Affects #65

@mikberg mikberg requested a review from a team as a code owner March 11, 2022 13:02
@mikberg mikberg force-pushed the no-push-in-collect branch 2 times, most recently from cc30dea to 7ec2522 Compare March 11, 2022 14:48
The option to make the `collect` command push the snapshot to remote
storage isn't used, and make our API more confusing. Let's remove it,
at least for now.
@mikberg mikberg merged commit 5585900 into main Mar 21, 2022
@mikberg mikberg deleted the no-push-in-collect branch March 21, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants