Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for cloud native multipart upload #103

Merged
merged 19 commits into from
Oct 27, 2023
Merged

Conversation

pavelzubarev
Copy link
Contributor

@pavelzubarev pavelzubarev commented Oct 25, 2023

Describe your changes

Checklist

  • I have added/updated the necessary documentation for the changes.
  • I have added/updated the tests for the changes.
  • I have updated the poetry version. Refer version upgrades.
  • I have updated the version in __init__.py
  • I have updated the CHANGELOG.md

@pavelzubarev pavelzubarev changed the title Azure implementation for multipart upload Implementation for cloud native multipart upload Oct 25, 2023
@pavelzubarev pavelzubarev marked this pull request as ready for review October 26, 2023 18:06
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #103 (f9ea02f) into main (c337507) will increase coverage by 1.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   96.16%   97.72%   +1.55%     
==========================================
  Files           4        8       +4     
  Lines         313      439     +126     
==========================================
+ Hits          301      429     +128     
+ Misses         12       10       -2     
Files Coverage Δ
cognite/cdffs/__init__.py 100.00% <100.00%> (ø)
cognite/cdffs/az_upload_strategy.py 100.00% <100.00%> (ø)
cognite/cdffs/gcp_upload_strategy.py 100.00% <100.00%> (ø)
cognite/cdffs/memory_upload_strategy.py 100.00% <100.00%> (ø)
cognite/cdffs/spec.py 97.29% <100.00%> (+1.12%) ⬆️
cognite/cdffs/upload_strategy.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@vminfant vminfant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR. Brilliant work! We need to add some tests for the upload strategy and Azure/GCP workloads but not an immediate priority. We can fix this later!

@pavelzubarev pavelzubarev merged commit 309457b into main Oct 27, 2023
4 checks passed
@pavelzubarev pavelzubarev deleted the multiparts branch October 27, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants