Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF-18848: [draft] try new creds in tests #731

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,11 @@ jobs:
./secrets/decrypt.sh secrets/secring.asc.gpg ~/.sbt/gpg/secring.asc
- name: Run tests
env:
TEST_API_KEY_WRITE: ${{ secrets.TEST_API_KEY_WRITE }}
TEST_OIDC_READ_CLIENT_ID: ${{ secrets.TEST_OIDC_READ_CLIENT_ID }}
TEST_OIDC_READ_CLIENT_SECRET: ${{ secrets.TEST_OIDC_READ_CLIENT_SECRET }}
TEST_OIDC_READ_TENANT: ${{ secrets.TEST_OIDC_READ_TENANT }}
TEST_CLIENT_ID_BLUEFIELD: ${{ secrets.BLUEFIELD_CLIENT_ID }}
TEST_CLIENT_SECRET_BLUEFIELD: ${{ secrets.BLUEFIELD_CLIENT_SECRET }}
TEST_AAD_TENANT_BLUEFIELD: "b86328db-09aa-4f0e-9a03-0136f604d20a"
AIZE_CLIENT_ID: ${{ secrets.AIZE_CLIENT_ID }}
AIZE_CLIENT_SECRET: ${{ secrets.AIZE_CLIENT_SECRET }}
TEST_CLIENT_ID_BLUEFIELD: ${{ secrets.BLUEFIELD_CLIENT_ID_2 }}
TEST_CLIENT_SECRET_BLUEFIELD: ${{ secrets.BLUEFIELD_CLIENT_SECRET_2 }}
TEST_AAD_TENANT_BLUEFIELD: ${{ secrets.TEST_AAD_TENANT_BLUEFIELD_2 }}
TEST_PROJECT: "spark-datasource-bluefield-tests"
dmivankov marked this conversation as resolved.
Show resolved Hide resolved
TEST_CLUSTER: "bluefield.cognitedata.com"
dmivankov marked this conversation as resolved.
Show resolved Hide resolved
run: |
TEST="test +Test/compile"
if [ ${{github.ref }} == "refs/heads/master" ]; then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,6 @@ class DataPointsRelationTest

val df = spark.read
.format("cognite.spark.v1")
.option("apiKey", jetfiretest2ApiKey)
.option("type", "datapoints")
.option("collectMetrics", "true")
.option("metricsPrefix", metricsPrefix)
Expand Down
9 changes: 8 additions & 1 deletion src/test/scala/cognite/spark/v1/SdkV1RddTest.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package cognite.spark.v1

import cats.effect.IO
import com.cognite.sdk.scala.common.CdpApiException
import com.cognite.sdk.scala.common.{CdpApiException, OAuth2}
import com.cognite.sdk.scala.v1.{Event, GenericClient}
import fs2.{Chunk, Stream}
import org.apache.spark.TaskContext
Expand Down Expand Up @@ -33,6 +33,13 @@ class SdkV1RddTest extends FlatSpec with Matchers with ParallelTestExecution wit
implicit val implicitBackend: SttpBackend[IO, Any] = CdpConnector.retryingSttpBackend(3, 5)

val sdkRdd = {
val readOidcCredentials = OAuth2.ClientCredentials(
tokenUri = uri"https://login.microsoftonline.com/fake-tenant/oauth2/v2.0/token",
clientId = "fake_client_id",
clientSecret = "fake_secret",
scopes = List("https://api.cognitedata.com/.default"),
cdfProjectName = "fake_project"
)
val relationConfig = getDefaultConfig(
CdfSparkAuth.OAuth2ClientCredentials(readOidcCredentials)(implicitBackend),
readOidcCredentials.cdfProjectName
Expand Down
46 changes: 10 additions & 36 deletions src/test/scala/cognite/spark/v1/SparkTest.scala
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ trait SparkTest {
val clientId = sys.env("TEST_CLIENT_ID_BLUEFIELD")
val clientSecret = sys.env("TEST_CLIENT_SECRET_BLUEFIELD")
private val aadTenant = sys.env("TEST_AAD_TENANT_BLUEFIELD")
val project = sys.env("TEST_PROJECT")
val cluster = sys.env("TEST_CLUSTER")
val tokenUri = s"https://login.microsoftonline.com/$aadTenant/oauth2/v2.0/token"
val project = "jetfiretest2"
val scopes = "https://api.cognitedata.com/.default"
val scopes = s"https://$cluster/.default"
}

val writeCredentials = OAuth2.ClientCredentials(
Expand All @@ -60,7 +61,7 @@ trait SparkTest {
val writeClient: GenericClient[IO] = new GenericClient(
applicationName = "jetfire-test",
projectName = writeCredentials.cdfProjectName,
baseUrl = s"https://api.cognitedata.com",
baseUrl = s"https://${OIDCWrite.cluster}",
authProvider = writeAuthProvider,
apiVersion = None,
clientTag = None,
Expand All @@ -85,42 +86,15 @@ trait SparkTest {
.option("scopes", OIDCWrite.scopes)
}

private val readClientId = System.getenv("TEST_OIDC_READ_CLIENT_ID")
// readClientSecret has to be renewed every 180 days at https://hub.cognite.com/open-industrial-data-211
private val readClientSecret = System.getenv("TEST_OIDC_READ_CLIENT_SECRET")
private val readAadTenant = System.getenv("TEST_OIDC_READ_TENANT")

assert(
readClientId != null && !readClientId.isEmpty,
"Environment variable \"TEST_OIDC_READ_CLIENT_ID\" was not set")
assert(
readClientSecret != null && !readClientSecret.isEmpty,
"Environment variable \"TEST_OIDC_READ_CLIENT_SECRET\" was not set")
assert(
readAadTenant != null && !readAadTenant.isEmpty,
"Environment variable \"TEST_OIDC_READ_TENANT\" was not set")

private val readTokenUri = s"https://login.microsoftonline.com/$readAadTenant/oauth2/v2.0/token"

val readOidcCredentials = OAuth2.ClientCredentials(
tokenUri = uri"$readTokenUri",
clientId = readClientId,
clientSecret = readClientSecret,
scopes = List("https://api.cognitedata.com/.default"),
cdfProjectName = "publicdata"
)

def dataFrameReaderUsingOidc: DataFrameReader =
spark.read
.format("cognite.spark.v1")
.option("tokenUri", readTokenUri)
.option("clientId", readClientId)
.option("clientSecret", readClientSecret)
.option("project", "publicdata")
.option("scopes", "https://api.cognitedata.com/.default")

// not needed to run tests, only for replicating some problems specific to this tenant
lazy val jetfiretest2ApiKey = System.getenv("TEST_APU_KEY_JETFIRETEST2")
.option("tokenUri", OIDCWrite.tokenUri)
.option("clientId", OIDCWrite.clientId)
.option("clientSecret", OIDCWrite.clientSecret)
.option("project", OIDCWrite.project)
.option("scopes", OIDCWrite.scopes)


val testDataSetId = 86163806167772L

Expand Down
Loading