Add simple test about DefaultSource class #773
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultSource should have default constructor for executors to be able to create it.
dmivankov
force-pushed
the
test_default_constructor
branch
from
0a21cba
to
6faaca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 49 49
Lines 3407 3407
Branches 152 152
=======================================
Hits 2626 2626
Misses 781 781 |
audunska
approved these changes
Aug 11, 2023
|
Yes, hit it during local development around adding tracing. Compiles fine with extra constraints but CI tests break (luckily they do catch it but a dedicated test would be more clear) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultSource should have default constructor for
executors to be able to create it.