Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom query can not find timeseries outside of the 10000 first #72

Open
martincognite opened this issue Jul 30, 2019 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@martincognite
Copy link
Contributor

We're doing client-side filtering to satisfy the regexes, and we're doing it optimistically. When there's attached more than the 10000 (the limit specified in our code), those won't get looked after.

A quick solution is to paginate all timeseries for the given asset instead of giving up after the first 10000.

Thoughts @hulien22 ?

@martincognite martincognite added the enhancement New feature or request label Jul 30, 2019
@hulien22
Copy link
Contributor

That's definitely something we would want, but I'm worried about the time it would take - especially if we consider including subassets, and then getting all the timeseries from a large root node. I have some of the pagination in place for the v1 update, but decided to limit those calls to only get the first 10000 timeseries as before due to some performance issues.
Being able to fetch all cursors will be able to help to introduce a bit more concurrency, but I still feel as though there will be some issues since browsers are limited to the number of requests they keep open at a time.

@gzarruk
Copy link

gzarruk commented Aug 12, 2019

Is there a workaround for this? This issue is blocking development of user dashboards

@polomani
Copy link
Contributor

so we have partitions now, and considering there is a limit on how many connections we can have in browser I'd probably suggest to split it by 4 partitions, and fetch that way.
don't really like that we do this stuff in frontend anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants