Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rerank (async client) does not have parameter return_documents #339

Open
cirezd opened this issue Nov 9, 2023 · 1 comment
Open

rerank (async client) does not have parameter return_documents #339

cirezd opened this issue Nov 9, 2023 · 1 comment

Comments

@cirezd
Copy link

cirezd commented Nov 9, 2023

https://github.com/cohere-ai/cohere-python/blob/5e9e872cd75ebea3c2091dd043b875b494f21535/cohere/client_async.py#L495C33-L495C38

Hello, the reranker (async client) does not have parameter return_documents. It is hard-coded to False in the code above.
@murdadesmaeeli
Copy link

Hi @cirezd, you might be right in that there might not be a specific reason for this hard coding. @mkozakov , @lfayoux can you confirm?

If there is no specific reason then this could be fixed with a simple PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cirezd @murdadesmaeeli