Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1319: Remove phase, sex, and form #19

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Remove phase, sex, and form from default template

Why are we doing this? (with JIRA link)

These fields are specific to Herbarium, Bonsai, Bot Garden and Anthro and are being hidden in lhmc.

How should this be tested? Do these changes have associated tests?

  • Run the devserver: npm run devserver --back-end=https://lhmc.dev.collectionspace.org
  • See that the 3 fields were removed from the template (under Object Description Information)

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
Noe

Did someone actually run this code to verify it works?
@mikejritter tested with lhmc.dev as a backend

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mikejritter mikejritter merged commit 3e36798 into collectionspace:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants