display a collection in a Bootstrap carousel

[ebrehault]

This PR allows to display collection items in a Bootstrap carousel.
Unlike Galleria (used in the existing Carousel tile) , the Bootstrap carousel is not restricted to images only, it can show any HTML content as slides.
That's the only reason why I made this change.
Nevertheless it might be quite confusing for users if 2 different tiles offer a carousel feature in 2 diferent ways...
So I am not sure it must be merged, but it is a way to launch a discussion about it.

closes #338

[hvelarde]

thanks, @ebrehault, he have been talking about this for some time now: check #442.

@agnogueira @djowett comments?

[djowett]

The main issue I see is that users probably won't find it, but rather go to the Carousel tile, though that doesn't mean it shouldn't be an option on a Collection tile (or a List tile too) .

(Obviously the content is built up in different ways - a Carousel Tile's objects are manually dropped in, whereas objects in a Collection Tile are automatically found by the collection)

If it is considered useful as an option, then I believe it should use the same Carousel library as the Carousel tile - whether we need to use Bootstrap or Cycle2 I couldn't say - unless Bootstrap follow Foundation by deprecating their Carousel.

[ebrehault]

I agree we cannot offer a Carousel tile on one side, and a Collection tile with carousel option on another side. That's totally confusing.
And it raises another problem: a List-based carousel is clearly useful, but a Collection-based carousel could be useful too.
So maybe we could remove the Carousel tile (as the carousel aspect is more about how we show the content, and not how we edit/choose the content), and just make the List and the Collection tiles "carouselable".

Just an idea, not sure it is accurate.

[hvelarde]

@ebrehault that's an interesting point and I think @agnogueira had an opinion about it.

[hvelarde]

meanwhile, could you please update your pull request? code analysis is failing

[marcosamm]

I needed to create a tile to make the display of a collection as carousel on the homepage of the company. The collection sorts and filters the news and the tile displays the photo and title of each news. I called him Collection Carousel.
The basic idea of my solution was to create a class with the implementation based on CollectionTile (inheritance) and visualization based on carousel.pt.
It is important to have a component that displays from a collection, displaying the standard for object image and allowing change the setting to display HTML content as slide.

[ebrehault]

@hvelarde Hi Hector, I have merged the last changes from master.

[coveralls]

Changes Unknown when pulling 76b4ee8 on ebr-display-collection-with-bootstrap-carousel into * on master*.

[hvelarde]

for me this makes a lot of sense: we can remove completely the carousel tile from the core, diminishing the complexity of the package and the number of dependencies, and adding the possibility of having a simple carousel for lists and collections OOTB.

on the other side we can let open the possibility of adding a carousel tile from outside, with as many options as needed, by using whatever library you may want.

the only risk I can foresee here is that we must provide a clear path for migration:

• by providing a carousel tile based on Galleria that you can just install and make all carousel tiles still usable
• or, just by migrating any instance of a carousel tile to a list with the new options set up.

and this could lead to broken layouts.

@runyaga @frapell @fredvd @mauritsvanrees @polyester @rodfersou comments?

[polyester]

I would be all in favour of having the List and Collection tiles be 'carouselable', and would not worry too much about migration. In all honesty, I've had all carousels break on various upgrades of collective.cover already, one more time is not going to matter that much. They were usually quick to fix manually. As long as the change is documented, I'm all for it.

My preferred option would therefore be:

• migrate them to a list with the new options set up
• present the site admin with the list of URL's of all carousel tiles found, so she or he can make manual amends.

The biggest problem was always finding out where on the site those pesky editors had added yet another carousel tile and then forgotten about them, so if this second step is possible in some log, that will mitigate all upgrade worries for me.