Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement restapi services to handle authentication flow #39

Merged
merged 13 commits into from
Nov 23, 2023

Conversation

ericof
Copy link
Member

@ericof ericof commented Nov 14, 2023

Fixes #38

@ericof ericof added the enhancement New feature or request label Nov 14, 2023
@ericof ericof requested review from mamico and erral November 14, 2023 20:18
@ericof ericof marked this pull request as ready for review November 16, 2023 19:17
DEVELOP.md Outdated Show resolved Hide resolved
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these endpoints together with the code on the main branch of volto-authomatic and it works perfectly.

I would somehow merge the documentation on DEVELOP.md and the existing on README.md regarding the configuration of KeyCloak.

I don't know if the best thing is to add this documentation in README and DEVELOP or perhaps add a new sphinx-based docs folder and deploy it to RTD.

DEVELOP.md Outdated Show resolved Hide resolved
@ericof ericof requested a review from erral November 20, 2023 22:28
@ericof
Copy link
Member Author

ericof commented Nov 23, 2023

@erral Is this good enough to be merged?

@mamico
Copy link
Collaborator

mamico commented Nov 23, 2023

@ericof in general everything looks ok to me too. this afternoon I have some time to do a second check and give a second opinion as well. thx.

Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks!

Copy link
Collaborator

@mamico mamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments. Otherwise absolutely awesome for me.


You need a working `python` environment (system, `virtualenv`, `pyenv`, etc) version 3.8 or superior.

Then install the dependencies and a development instance using:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not (yet) generally using pip. For me make install was not enough, I also had to do:

python3.11 -m venv .
bin/pip install cookiecutter mxdev -c contraints.txt

Have I made a mistake or forgotten something?

src/pas/plugins/oidc/services/oidc/oidc.py Show resolved Hide resolved
@mamico
Copy link
Collaborator

mamico commented Nov 23, 2023

@ericof @erral is it okay for you, if I invite you to the pypi project?

@erral
Copy link
Member

erral commented Nov 23, 2023

Ok.

@ericof
Copy link
Member Author

ericof commented Nov 23, 2023

@mamico Please, also invite the collective user

@ericof ericof merged commit 2ffa062 into main Nov 23, 2023
5 checks passed
@ericof ericof deleted the issue-38-services branch November 23, 2023 18:58
@ericof
Copy link
Member Author

ericof commented Nov 23, 2023

@mamico Just confirming: users collective and ericof on pypi :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement plone.restapi services to handle headless authentication flow
3 participants