Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio package redux #108

Open
collinsmith opened this issue Aug 28, 2020 · 0 comments
Open

Audio package redux #108

collinsmith opened this issue Aug 28, 2020 · 0 comments

Comments

@collinsmith
Copy link
Owner

Riiablo.audio will need to be rewritten. Support for implementing various features of sound.txt excel are not immediately critical, but some API changes are needed.

Currently, sounds are played via Riiablo.audio.play(String,boolean) where boolean refers to whether or not that sound is client-local or server-side (which affects the path to the sound file). I'd like to remove this dependency and just play the sound. Defining a boolean-parameterless overload is only viable if the locality of the sound file can be determined, otherwise I'd rather not have it default to use one or the other due to potential bugs.

This may be due to some dependency of the game to understand state, e.g., client-local code will have it's MPQ sub-path set to client-local file paths, and server otherwise. I can't say for sure if this is how it works in practice. My fear if the above is true, is that this issue will rely on changes that need to be done in MPQ (i.e., mpq resolver will need to mount data/global or data/local).

FYI, local sound files are basically just voice overs and entity dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant