Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitInput#readSlice initial state of bitsRead #128

Open
collinsmith opened this issue Nov 23, 2020 · 0 comments
Open

BitInput#readSlice initial state of bitsRead #128

collinsmith opened this issue Nov 23, 2020 · 0 comments
Labels

Comments

@collinsmith
Copy link
Owner

6be4e48 changed a problematic test case to pass stemming from a change made to BitInput#readSlice where the slice starts with an initial state of slice.bitsRead = parent.bitsRead. Should this be the expected value and not 0 bits read?

This method was added when changes were made to the DCC codec reading different compressed streams as slices so that an assertion can be made on the number of bits were read from the stream. Need to look into this and provide documentation for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant