Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes.java line 234 parameter type should change from short to int. #144

Open
zxh9813 opened this issue Jan 8, 2022 · 3 comments
Open

Attributes.java line 234 parameter type should change from short to int. #144

zxh9813 opened this issue Jan 8, 2022 · 3 comments
Labels
stat

Comments

@zxh9813
Copy link

zxh9813 commented Jan 8, 2022

I am able to run after changing below parameter from short to int
图片
@collinsmith
Copy link
Owner

iirc, this is expected behavior. stat should be a constant and within a known range unsigned 0..0x1f, all places this function is used should be read and cast to short anyways. Was there a specific problem in another area?

@zxh9813
Copy link
Author

zxh9813 commented Jan 8, 2022

After I changing Attributes.java and StatListRef.java. I was able to start it.

@collinsmith
Copy link
Owner

I can start without that change. What error were you getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zxh9813 @collinsmith