Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] open modal when screen has options presentation: "modal" #125

Closed
vietanhdtd opened this issue Sep 22, 2023 · 4 comments · Fixed by #149
Closed

[iOS] open modal when screen has options presentation: "modal" #125

vietanhdtd opened this issue Sep 22, 2023 · 4 comments · Fixed by #149
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vietanhdtd
Copy link

I have encountered a problem when using a modal on a screen that has the option presentation: "modal". The modal always shows up behind it.

To address this issue, I came up with a workaround that involves wrapping the screen content with ModalProvider. However, this approach results in opening two modals, and I am unable to close the modal on a screen with presentation: "modal".

If anyone has a better solution for this case, please share it with me. Thank you.

@CharlesMangwa CharlesMangwa self-assigned this Sep 25, 2023
@CharlesMangwa CharlesMangwa added bug Something isn't working repro needed Reproducible demo app/Expo Snack is needed labels Sep 25, 2023
@CharlesMangwa
Copy link
Member

hey @vietanhdtd! could you provide a repro on snack please?

@vietanhdtd
Copy link
Author

@CharlesMangwa thank you for responding. Here's snake of the problem i mention above:

https://snack.expo.dev/@vietanhdtd/modalfy-screen-presentation-modal

CleanShot 2023-09-25 at 11 54 51

And only happen on iOS.

@vietanhdtd vietanhdtd changed the title open modal when screen has options presentation: "modal" [iOS] open modal when screen has options presentation: "modal" Jan 29, 2024
@CharlesMangwa CharlesMangwa added good first issue Good for newcomers and removed repro needed Reproducible demo app/Expo Snack is needed labels Mar 8, 2024
@CharlesMangwa
Copy link
Member

hey @vietanhdtd! sorry for the delayed response. unfortunately, i do not have an idea how to address your issue effectively. i'd need to spend some more time trying things before i can potentially release a patch. apologies for the inconvenience.

@fobos531
Copy link
Contributor

Hello @CharlesMangwa, I opened a PR #149 which fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants