You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I spotted some outdated documentation in the VoteInfo reference docs for CometBFT v0.38. The docs document having a last_signed_block field, which is a boolean. This is accurate for CometBFT v0.37, which has the following VoteInfo struct:
In CometBFT v0..38, this was changed to an enumerator:
typeVoteInfostruct {
ValidatorValidator`protobuf:"bytes,1,opt,name=validator,proto3" json:"validator"`BlockIdFlag types1.BlockIDFlag`protobuf:"varint,3,opt,name=block_id_flag,json=blockIdFlag,proto3,enum=tendermint.types.BlockIDFlag" json:"block_id_flag,omitempty"`
}
// types1 package:// BlockIdFlag indicates which BlockID the signature is fortypeBlockIDFlagint32const (
BlockIDFlagUnknownBlockIDFlag=0BlockIDFlagAbsentBlockIDFlag=1BlockIDFlagCommitBlockIDFlag=2BlockIDFlagNilBlockIDFlag=3
)
I believe this change was made due to vote extensions. I would create a PR fixing this, however I am unsure what each of the enumerators means (which is why I had to reference the docs in the first place). Any help from someone with more context on what each of these means would be very helpful! If there's somewhere else where I can find this info, I'm happy to make the updates myself and make a PR.
The text was updated successfully, but these errors were encountered:
I spotted some outdated documentation in the
VoteInfo
reference docs for CometBFT v0.38. The docs document having alast_signed_block
field, which is a boolean. This is accurate for CometBFT v0.37, which has the followingVoteInfo
struct:In CometBFT v0..38, this was changed to an enumerator:
I believe this change was made due to vote extensions. I would create a PR fixing this, however I am unsure what each of the enumerators means (which is why I had to reference the docs in the first place). Any help from someone with more context on what each of these means would be very helpful! If there's somewhere else where I can find this info, I'm happy to make the updates myself and make a PR.
The text was updated successfully, but these errors were encountered: