Update protos to recent CometBFT in main, with RFC 106 and skip_extension_signing #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CometBFT 1.0.0-alpha.1, there was one significant change: GetLatest* methods were removed from the data companion API as per RFC 106. Regenerate cometbft-proto from a recent cometbft commit that includes the changes.
NOTE: the default is set to true when converting from earlier version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
======================================
Coverage ? 57.1%
======================================
Files ? 254
Lines ? 27597
Branches ? 0
======================================
Hits ? 15771
Misses ? 11826
Partials ? 0 ☔ View full report in Codecov by Sentry. |
The cometbft.privval.v1.SignVoteRequest message had the recently added sign_extension field renamed to skip_extension_signing. Change the source commit and regenerate the protos.
The sign_extension field was renamed to skip_extension_signing with flipped value semantics.
mzabaluev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CometBFT 1.0.0-alpha.1, there were a couple of significant changes to proto files:
GetLatest*methods were removed from the data companion API as per RFC 106.skip_extension_signingflag was added tocometbft.privval.v1.Regenerate
cometbft-protofrom a recent cometbft commit that includes the changes..changelog/