Skip to content

Commit

Permalink
fix: Upgrade to ESLint 8 and fix plugin compatibility issues (#34)
Browse files Browse the repository at this point in the history
* manually bump versions of some plugins to fix breaking changes with ESLint v8

* BREAKING CHANGE: upgrade eslint peer dependency to v8

* Add README note about v2 breaking change

BREAKING CHANGE: This package now requires ESLint 8

Co-authored-by: Seb Aebischer <[email protected]>
  • Loading branch information
pauldolden and seb-cr authored Aug 8, 2022
1 parent 389cd52 commit d379b40
Show file tree
Hide file tree
Showing 3 changed files with 439 additions and 398 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

Shared ESLint configuration for Comic Relief codebases.

**As of version 2.0.0, we require ESLint 8.** Older versions of ESLint have compatibility issues with some plugins and are no longer supported.

## Usage

1. Install `eslint` if you haven't already done so.
Expand Down
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@
"author": "Comic Relief",
"license": "MIT",
"peerDependencies": {
"eslint": ">=7.6.0"
"eslint": "^8.17.0"
},
"devDependencies": {
"semantic-release": "^17.1.1"
},
"dependencies": {
"@babel/eslint-parser": ">=7.11.3",
"@babel/eslint-parser": "^7.11.3",
"@typescript-eslint/parser": "^4.7.0",
"eslint-config-airbnb": "^18.2.1",
"eslint-config-airbnb-base": "^14.2.1",
"eslint-plugin-flowtype": ">=5.2.0",
"eslint-plugin-import": ">=2.3.0",
"eslint-plugin-jsdoc": "^30.7.7",
"eslint-plugin-jsx-a11y": ">=6.2.3",
"eslint-plugin-react": ">=7.20.5",
"eslint-plugin-sonarjs": ">=0.5.0",
"eslint-plugin-unicorn": ">=21.0.0",
"eslint-plugin-flowtype": "^8.0.3",
"eslint-plugin-import": "^2.3.0",
"eslint-plugin-jsdoc": "^39.3.2",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-react": "^7.30.0",
"eslint-plugin-sonarjs": "^0.13.0",
"eslint-plugin-unicorn": "^42.0.0",
"typescript": "^4.0.5"
},
"publishConfig": {
Expand Down
Loading

0 comments on commit d379b40

Please sign in to comment.