Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$300 bounty] nav: switch to MapLibre widget #26739

Closed
adeebshihadeh opened this issue Dec 9, 2022 · 7 comments · Fixed by #31185
Closed

[$300 bounty] nav: switch to MapLibre widget #26739

adeebshihadeh opened this issue Dec 9, 2022 · 7 comments · Fixed by #31185
Labels

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Dec 9, 2022

Seems like it's being actively developed now: https://github.com/maplibre/maplibre-gl-native.

Bounty is for making the simplest PR that moves to MapLibre. Requirements:

  • performance must be same or better
  • map must look the same (or very good reason if not)

This can be done on PC, and we can do final testing on a comma 3X.

@birkskyum
Copy link

Hi, I'm part of the MapLibre Board, and wanted to give you a status on this.

MapLibre Native is indeed being being actively developed now, with staff maintenance to secure that PRs are reviewed, that CI is running and that docs are deployed. There are open technical steering committee meetings hosted monthly, and a consistent inflow of PRs from Meta, AWS and other companies investing in the renderer. It seems like you use a Qt widget - we have releases for both Qt and for QML, supporting up to Qt 6.4.

The best points of contacts for technical questions are:

The key objective for MapLibre Native in 2023 is to add support for Metal, because currently only OpenGL v3 is supported. This process is undertaken by WetDogWeather and is well underway.

@birkskyum
Copy link

Watching the talk made by @mitchellgoffpc at COMMA_CON 2023, it seems like some challenges hit here that can be resolved upstream in MapLibre are:

  • Fixed scale, dynamically zooming in/out to account - Issue inherent to with mercator tiles. Investing in adaptive projections / Globe view can help resolve this.
  • Speed limits - The new data format presented by Overture Map Foundation can help unlock this type of data, which is somewhat tricky in the OSM data format. Tracking issue for Planetiler support

@adeebshihadeh adeebshihadeh changed the title nav: switch to MapLibre widget [$300 bounty] nav: switch to MapLibre widget Dec 12, 2023
@adeebshihadeh adeebshihadeh added bounty good first issue Feasible for new contributers labels Dec 12, 2023
@jnewb1 jnewb1 moved this to Open in openpilot bounties Dec 18, 2023
@birkskyum
Copy link

birkskyum commented Jan 19, 2024

It's been half a year since my last status on where MapLibre is. As mentioned previously, the target for MapLibre in 2023 was to refactor the render to support multiple graphics backends, and then add Metal support. That work completed on schedule and Metal support is now released.

Since OpenPilot isn't running on an Apple device, Metal won't make a difference here, but there has been quite some improvements/modernization to the OpenGL backend as well, so I'd expect a performance improvement as a result of this drop-in replacement.

@adeebshihadeh
Copy link
Contributor Author

Great, thanks for the update. I think someone will pick this up soon now that there's a bounty.

@birkskyum
Copy link

birkskyum commented Jan 19, 2024

@adeebshihadeh , is OpenPilot btw. running on Android, or is it Qt / Linux?

@adeebshihadeh
Copy link
Contributor Author

openpilot targets Linux

@jnewb1 jnewb1 linked a pull request Jan 27, 2024 that will close this issue
@jnewb1 jnewb1 moved this from Open to Locked in openpilot bounties Jan 27, 2024
@github-project-automation github-project-automation bot moved this from Locked to Done in openpilot bounties Feb 1, 2024
@birkskyum
Copy link

birkskyum commented Mar 26, 2024

@adeebshihadeh , there will be a MapLibre Navigation meeting on April 11th, at 18 CET (1 hour, leading up to the recurrent TSC meetings for MapLibre Native/GL JS), if anyone from the OpenPilot team or community would like to join. It's a good opportunity to share your interests, to make sure the direction of the libraries align with your use cases.

It's completely open - and this is some bullet from a tentative agenda to give an idea what will happen:

  • Give everyone who has a use case for nav a chance to share what they’re looking for and the challenges they see.
  • Give everyone who’s somewhat actively working on something nav related a chance to talk about what they’re building, why, the unique use cases, constraints, etc. that they have, and so on.
  • Identify areas where we’d like to see MapLibre Native improve to be more suitable for navigation (ex: camera and puck) for our various projects.
  • Identify any other areas where we can consolidate efforts / collaborate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants