Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN FD: use less of the part number for fuzzy FP #29989

Closed
sshane opened this issue Sep 20, 2023 · 5 comments
Closed

Hyundai CAN FD: use less of the part number for fuzzy FP #29989

sshane opened this issue Sep 20, 2023 · 5 comments

Comments

@sshane
Copy link
Contributor

sshane commented Sep 20, 2023

We're getting PRs like #29962 and #29988 (ignore new part date) where the part number's suffix increments indicating some sort of part revision, but the major first two characters remain the same. Explore reducing the part number for fingerprinting to just the first characters. It still catches the Tucson with the different tuning, as well as #29949 which we don't want to merge for the same reason.

Similar to #29572

@sshane
Copy link
Contributor Author

sshane commented Sep 23, 2023

#30020 would also fingerprint with this.

@sshane
Copy link
Contributor Author

sshane commented Oct 10, 2023

Something like this: 47207e2

@sshane
Copy link
Contributor Author

sshane commented Oct 10, 2023

Though we do have to be careful. Here's an example of the same first two characters in the part number for a new 2024 Elantra fwdRadar, however they switched from having it send SCC to just being a radar. The only thing that would prevent it from matching with this is the date code in the camera (which also has the same first two characters). #30219

  • Consider SCC/RDR or decide this is safe with plaintext date code

dongle: 784a39c0a9dd3493

# 2021
b'\xf1\x00CN7_ SCC FNCUP      1.00 1.01 99110-AA000         ',
# 2024
b'\xf1\x00CN7_ RDR -----      1.00 1.01 99110-AA500         ',

@gregjhogan
Copy link
Member

Fuzzy fingerprinting on things we understand (platform codes, dates, software version numbers) seems fairly safe. I am not sure how we make any safe assumptions about the future if extend to components we don't understand what the values represent.

@sshane
Copy link
Contributor Author

sshane commented Mar 30, 2024

We don't understand the part numbers enough yet for this. Can revisit in the future

@sshane sshane closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants