Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible athenad memory leak #34079

Open
sshane opened this issue Nov 21, 2024 · 1 comment
Open

Possible athenad memory leak #34079

sshane opened this issue Nov 21, 2024 · 1 comment
Labels
Milestone

Comments

@sshane
Copy link
Contributor

sshane commented Nov 21, 2024

It was using 15% of memory, causing low memory events. I had not rebooted the device in a few days iirc and had uploaded many rlogs.

I tried to attach with memray, but instead the process just crashed so I didn't get any information about this. @deanlee could this be similar to the leak you found in athena previously?

@sshane sshane added the bug label Nov 21, 2024
@sshane sshane added this to the 0.9.8 milestone Nov 21, 2024
@deanlee
Copy link
Contributor

deanlee commented Nov 22, 2024

It's hard to identify the exact issue, as the code is unclear and difficult to understand. However, multiple factors could be causing the resource leak. One possibility is that the athenad's implementation might cause garbage collector to accumulate objects over time, leading to memory issues during long runs.
additionally, thread race conditions related to queue and other global variable (like cur_upload_items, cancelled_uploads,...) usage, as well as bad practices like not calling task_done() after queue.get(), could also contribute to issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants