Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEC-138] React default props codemod tests #3683

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[FEC-138] React default props codemod tests #3683

wants to merge 5 commits into from

Conversation

CarlosCortizasCT
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT commented Dec 20, 2024 •
edited
Loading

Summary

React default props codemod tests.

Description

I added a new test-utils file to be able to test async codemods as the utilities jscodeshift exposes lack of this feature.

NOTE: I created this PR in the library repository requesting to add the async support natively.

@CarlosCortizasCT CarlosCortizasCT added the fe-chapter-rotation Tasks coming from frontend chapter work label Dec 20, 2024
@CarlosCortizasCT CarlosCortizasCT self-assigned this Dec 20, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 9:32am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 9:32am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 41f4b5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from fec-128-adjust-js-components to main December 23, 2024 10:57
@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review December 23, 2024 11:05
@CarlosCortizasCT CarlosCortizasCT requested a review from a team as a code owner December 23, 2024 11:05
tdeekens
tdeekens approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Documents all those cases really well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

Assignees

@CarlosCortizasCT CarlosCortizasCT

Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosCortizasCT @tdeekens