Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Yazdan Mohammadi <[email protected]>
  • Loading branch information
Oded-B and yzdann authored Dec 12, 2024
1 parent be4d974 commit 78f43e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions internal/pkg/githubapi/pr_metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ func isPrStalePending(commitStatuses *github.CombinedStatus, timeToDefineStale t
return false
}

// getPrMetrics itterates through all clients , gets all repos and then all PRs and calculates metrics
// This assumes Telefonsitka uses a GitHub App style of authentication as it uses the Apps.ListRepos call
// getPrMetrics iterates through all clients , gets all repos and then all PRs and calculates metrics
// getPrMetrics assumes Telefonsitka uses a GitHub App style of authentication as it uses the Apps.ListRepos call
// When using personal access token authentication, Telefonistka is unaware of the "relevant" repos (at least it get a webhook from them).
func getPrMetrics(mainGhClientCache *lru.Cache[string, GhClientPair]) {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Minute)
Expand Down
4 changes: 0 additions & 4 deletions internal/pkg/githubapi/pr_metrics_test.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
package githubapi

// @Title
// @Description
// @Author
// @Update
import (
"testing"
"time"
Expand Down

0 comments on commit 78f43e7

Please sign in to comment.