Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing enumeration for error type #59

Open
rcocks opened this issue Sep 14, 2016 · 1 comment
Open

Missing enumeration for error type #59

rcocks opened this issue Sep 14, 2016 · 1 comment

Comments

@rcocks
Copy link

rcocks commented Sep 14, 2016

A call to GET https://api.companieshouse.gov.uk/company/{company_number}/exemptions with a company with no exemptions or a company that does not exist returns an error company-exemptions-not-found. This error is not listed in errors.yml .

@AntoCuc
Copy link

AntoCuc commented Feb 8, 2017

Rather than returning an error. Or adding the error described by @rcocks to errors.yml shoudn't this service gracefully return a companyExceptions resource as described at https://developer.companieshouse.gov.uk/api/docs/company/company_number/exemptions/companyExemptions-resource.html with an empty list of exceptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants