Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Legacy #426

Open
yck011522 opened this issue May 10, 2024 · 2 comments
Open

Remove Legacy #426

yck011522 opened this issue May 10, 2024 · 2 comments
Milestone
General Cleanup

Comments

@yck011522
Copy link
Contributor

I think it is time to remove the following 4 functions in favor of compas.Data. Especially for the compas_fab 1.0 release.

  • write_data_to_json
  • read_data_from_json
  • write_data_to_pickle
  • read_data_from_pickle

https://github.com/compas-dev/compas_fab/blob/main/src/compas_fab/utilities/file_io.py#L44-L111

Does anyone have reservations?
@yck011522
Copy link
Contributor Author

@gonzalocasas @chenkasirer @romanarust ping.

Any thoughts about the removal of these?

@gonzalocasas
Copy link
Member

Agree! Probably read_csv_to_dictionary also needs to go, I don't think it's used currently anywhere in fab, and if it's not, it is not a good place for it as a generic util.

@yck011522 yck011522 added this to the General Cleanup milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
General Cleanup
Development

No branches or pull requests
2 participants
@gonzalocasas @yck011522