Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack and insist on Julia version upgrade #411

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

willtebbutt
Copy link
Member

In #377 we introduced a hack which ensured that code was loaded in roughly the correct order when extensions depended upon other extensions. Happily this ceased to be necessary in 1.11.2, so this PR

  1. removes the hacky code
  2. modifies the Julia compat bound to ensure that people still running 1.11.0 or 1.11.1 do not see this problem.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@yebai
Copy link
Contributor

yebai commented Dec 5, 2024

I think you can also move FunctionWrappers to weakdeps now.

@willtebbutt
Copy link
Member Author

willtebbutt commented Dec 5, 2024

Good point -- I'll give that a try.

edit: I'll give that a try in a follow-up PR.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     70.9 │     1.0 │         5.7 │ missing │
│                  _sum_1000 │     6.69 │  1360.0 │        34.2 │ missing │
│               sum_sin_1000 │     2.25 │    1.69 │        10.4 │ missing │
│              _sum_sin_1000 │     2.71 │   264.0 │        13.5 │ missing │
│                   kron_sum │     81.5 │    4.13 │       259.0 │ missing │
│              kron_view_sum │     57.1 │    9.43 │       208.0 │ missing │
│      naive_map_sin_cos_exp │     2.52 │ missing │        7.41 │ missing │
│            map_sin_cos_exp │     2.75 │    1.51 │        5.98 │ missing │
│      broadcast_sin_cos_exp │     2.58 │    3.06 │        1.46 │ missing │
│                 simple_mlp │     3.15 │    1.32 │        6.63 │ missing │
│                     gp_lml │     4.63 │    2.27 │     missing │ missing │
│ turing_broadcast_benchmark │      3.3 │ missing │        24.8 │ missing │
│         large_single_block │     4.03 │  4380.0 │        30.3 │ missing │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 16b8500 into main Dec 5, 2024
74 checks passed
@willtebbutt willtebbutt deleted the wct/remove-1-11-1-hack branch December 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants