Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block editor #70

Open
wants to merge 58 commits into
base: wizard-translations-redux
Choose a base branch
from
Open

Block editor #70

wants to merge 58 commits into from

Conversation

jthrilly
Copy link
Member

@jthrilly jthrilly commented Nov 7, 2024 •
edited by buckhalt
Loading

This PR implements a proof of concept of the block editor concept using TipTap.

UI components: based on radix components

  • Dropdown menu
  • Toolbar

Custom TipTap node types:

  • Variable, label, hint
  • Group
  • Dropcursor (adapted from prosemirror dropcursor)

TipTap components:

  • NodeBubbleMenu based on Toolbar and Tiptap Bubble menu
  • Basic variable menu-- text formatting, content type dropdown, required, delete
  • Group menu -- number of cols, group-level required, delete
  • Add node menu

Features:

  • Drag and drop variables, content, group components from side panel into editor. Only into valid drop locations.
  • Add variables, content, group components from plus icon menu at bottom of editor

jthrilly and others added 24 commits October 30, 2024 13:39
@jthrilly
component reorganization
5506e77
@jthrilly
heading and paragraph
9212b18
@jthrilly
wip additional extensions
9efe94d
@jthrilly
remove figure
ee60603
@jthrilly
add nodes
cd29821
@buckhalt
features: bubble menu, link
460933d
@buckhalt
menu button component, ability to delete link
a9056c8
@buckhalt
use useEditorState hook for states
4096ace
@buckhalt
first pass at variable drop into editor
e819a99
@buckhalt
rm unused extension
1986f67
@buckhalt
working example of editing variables
503bfed
@buckhalt
fix: allow drag of variables already in content area
7fad348 
must add data-type value to customNodes array in config for any added custom nodes
@buckhalt
render variable components as they will appear on the form
b3b8709 
allows editing label
@buckhalt
fix edit
5fa4273
@buckhalt
refactor: individual label, control nodes make parent variable node
6b76874
@buckhalt
improve varaiable subcomponents
2d53ba5
@buckhalt
fix edit by disallowing content in control
dc3df52
@buckhalt
feature: hint node in variable
8df20a1
@buckhalt
prevent drag of hint and label out of variable
a09dcbe
@buckhalt
add placeholder extension
839b90d
@buckhalt
implement label and hint placeholders
186103c 
implemented directly, no need for tiptap extension
@buckhalt
clean up types, errors, pull variable utils out for improved readability
2aa7d40
@buckhalt
make hint optional
2b70185
@buckhalt
integrate with schema work
aebb715
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio ❌ Failed (Inspect) Dec 9, 2024 9:30pm
studio-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:30pm

@jthrilly jthrilly changed the base branch from main to wizard-translations-redux November 7, 2024 14:27
@buckhalt
variable hover menu for delete/edit, rm control node type
2c488fc 
refactored variable nodes structure to directly render control within the variable after the label, hint. allows for easier control of attributes and removes unneccessary nesting
@buckhalt
refactor isValidDropPosition to be generalizable to all dropped elements
d189437 
also refactor the func to define valid drop positions instead of invalid
@buckhalt buckhalt marked this pull request as ready for review December 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jthrilly @buckhalt