Skip to content

Commit

Permalink
closes #6
Browse files Browse the repository at this point in the history
  • Loading branch information
@tobydriscoll
tobydriscoll committed Jun 11, 2024
1 parent 67065d3 commit 6011847
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
2 changes: 1 addition & 1 deletion ext/RFAMakieExt.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Plot the convergence history of a `Barycentric` or `Approximation` rational func
Markers show the maximum error on (the boundary of) the domain as a function of the numerator/denominator degree. A red marker indicates that the approximation has disallowed poles in its domain. A gold halo highlights the best approximation.
"""
RFA.convergenceplot(r::RFA.Approximation) = RFA.convergenceplot(r.fun)
RFA.convergenceplot(r::RFA.Approximation) = convergenceplot(r.fun)
function RFA.convergenceplot(r::Barycentric)
ismissing(r.stats) && error("No convergence data")
fig = Figure( )
Expand Down
18 changes: 4 additions & 14 deletions src/RationalFunctionApproximation.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,12 @@ include("operations.jl")
# These are overloaded by plotting extensions.
export convergenceplot, errorplot

function convergenceplot(args...; kwargs...)
ext = Base.get_extension(@__MODULE__, :Extension)
if ext === nothing
error("Load the Makie or Plots package first.")
else
return ext.convergenceplot(args...; kwargs...)
end
function convergenceplot(::Any)
error("Load the Makie or Plots package first.")
end

function errorplot(args...; kwargs...)
ext = Base.get_extension(@__MODULE__, :Extension)
if ext === nothing
error("Load the Makie or Plots package first.")
else
return ext.errorplot(args...; kwargs...)
end
function errorplot(::Any; kwargs...)
error("Load the Makie package first.")
end

end # module

2 comments on commit 6011847

@tobydriscoll
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/108757

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.2 -m "<description of version>" 60118473564a9c1fc794b769ccff70fda830255e
git push origin v0.1.2

Please sign in to comment.