Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic splines? #50

Open
tobydriscoll opened this issue Dec 17, 2014 · 1 comment
Open

Periodic splines? #50

tobydriscoll opened this issue Dec 17, 2014 · 1 comment
Labels

Comments

@tobydriscoll
Copy link
Member

Do we want to use periodic splines? Why not specify them using trig interpolants? I'm concerned about the limitation to fourth order accuracy for smooth boundaries.

Perhaps (at the risk of complexity) there needs to be a periodic-closed-curve class with subclassed implementations.

@ehkropf
Copy link
Collaborator

ehkropf commented Jan 3, 2015

The periodic splines are there because I was using them for various experiments. I've found them useful for being able to specify arbitrary smooth-ish boundaries. They probably should be done using trig interpolates; the current code was based on some older stuff I used trying to save time.

Any parameterised closed curve should probably be considered periodic. It makes sense to me to create a periodic/parameterised subclass of closed curve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants