-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming of classes line, circle, polygon, etc. #52
Comments
I think we should use a combination of 1 and 3. Since On the other hand, given someone is using the toolkit, classes like I think we should leave the |
I don't know...I'm getting less happy as I go. I'm up to zline, zgrid, zrectangle, and zbox so far. Ugly. I suppose there's option 3a. Prefix everything with 'cmt' or just 'cm'. |
Ugh, I see, matlab toolbox function name clashes. I hesitate to use the 'cm' prefix, but I guess it's no worse than 'z'. Other than 'z' indicates a "complex number" version, or something special, but then why not do all of the basic boundary/region classes like this? Having said that, 'cm' also denotes something special, but then its between
I could live with these. But then do we also prefix map class names? If not, why would they be special? But the alternative, putting |
No resolution yet, but the cmt. namespace is probably just too clunky to contemplate. Here's a kind of logic. Geometric objects, which could be 2D real or complex, will all get the z prefix. Nothing else needs it. (?) |
I can buy into that scheme. The consistency it applies to geometric objects makes sense. Though are we classing only closed curves as 2d objects or do region objets fall into this category as well? We have |
There is some reason for caution when it comes to the classes line, circle, disk, polygon, and ellipse, namely that these are very common and generic names that easily clash with user choices. The options I see are:
My approach in the early version was to use number 3 with the line class only, and leave the others naked.
The text was updated successfully, but these errors were encountered: