Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train, test and validation in modelling #31

Open
JGarciaCondado opened this issue Apr 10, 2024 · 2 comments · May be fixed by #58
Open

Train, test and validation in modelling #31

JGarciaCondado opened this issue Apr 10, 2024 · 2 comments · May be fixed by #58
Assignees
@itellaetxe
Labels
enhancement New feature or request
Milestone
Release 1.0

Comments

@JGarciaCondado
Copy link
Contributor

The software package already has minimum cross validation strategies implemented but there are a few adjustments to make.

  • There should be the option to split the data into train, validation and test. Currently controls are all used in a CV strategy and there is no separate test group.
  • Another option is to allow users to choose the CV strategy by using the import command (e.g. “-cv from sklearn.cross_validation import LeaveOneOut”)
  • The training, validation and test ids of each subject should be saved as a .txt for reproducibility.
  • In classification currently there is no warning if the dataset is unbalanced. A warning should be thrown and if possible the user should be given the option to balance the dataset by simple subsampling the largest group to reduce it to the smallest group. A heuristic approach for unbalanced could be 25% more data in one group than the other or something along those lines.
@JGarciaCondado JGarciaCondado added the enhancement New feature or request label Apr 10, 2024
@JGarciaCondado JGarciaCondado added this to the Release 1.0 milestone Apr 15, 2024
@JGarciaCondado
Copy link
Contributor Author

We also have a problem with how we do the cross validation. This should be done like the following for each of the cases.

  1. No hypeparameter tunning:

We have cross validation and get train and validation metrics as well as deltas for each of the subjects in the validation set. Then we apply to test and show test.

  1. Hyperparameter tunning:

Use grid search on validation set to obtain best hyperparameters and from this obtain both the train and val scores as well as the predictions. Then apply best model to test.

  1. Hyperopt:

Split into train and test. Apply hyperopt to train and then apply to test.

At the end in all train the model with all CN for further predictions with others.

We should somehow notify which controls are from validation and which are for test.

@itellaetxe itellaetxe self-assigned this Oct 14, 2024
@itellaetxe itellaetxe linked a pull request Oct 16, 2024 that will close this issue
ENH: Adds selective hyperparameter optimization #58
Open
@JGarciaCondado
Copy link
Contributor Author

We have move the need to warn about unbalanced datasets to a different issue. Also implementing different CV strategies can become quite complicated and does not add much extra value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itellaetxe itellaetxe

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

ENH: Adds selective hyperparameter optimization compneurobilbao/ageml
2 participants
@JGarciaCondado @itellaetxe