Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Add Images to Build (Workaround?) #160

Open
dominicbarnes opened this issue Feb 6, 2014 · 3 comments
Open

Cannot Add Images to Build (Workaround?) #160

dominicbarnes opened this issue Feb 6, 2014 · 3 comments

Comments

@dominicbarnes
Copy link

I'm trying to put together a builder plugin to assemble images into a sprite during the build, but can't seem to inject images, only styles.

Using component 0.19 (w/ builder 0.10) Builder#addFile("images", ...) doesn't behave like I would expect. It turns out that static assets like images/fonts/etc don't have a hook, and are fired off right away, so the copy/link operation is likely done (or at least in-flight) before I can get to it.

Is this changed in the later versions of the builder? (v0.11+) Is there a recommended workaround right now?

@ianstormtaylor
Copy link
Contributor

yeah this would be accessible in the newest version of the builder since you could choose not to copy them over and to instead sprite em

@dominicbarnes
Copy link
Author

In my particular case, I'm using a separate sprite config, rather than images. (although either could be reasonable)

Should I just make a custom build script using the newest builder.js? (are there any incompatibilities or breaking changes I may need to be aware of?)

@ianstormtaylor
Copy link
Contributor

yeah sprites makes sense to be able to know which are not to be sprited. builder plugin would be good, although i'm currently waiting on #151 before i get too into using the new api cuz we gotta solve the verbosity stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants