Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update default ui #39

Merged
merged 23 commits into from
Sep 24, 2024
Merged

feat: update default ui #39

merged 23 commits into from
Sep 24, 2024

Conversation

TamaraBogantseva
Copy link
Contributor

@TamaraBogantseva TamaraBogantseva commented Aug 22, 2024 •
edited
Loading

Checklist

Reviewer

  • I've checked out the code and tested it myself.

Changes

  • Add options to change labels / text in Flottform component
  • Use css variables to allow developers change styles easily
  • Add anchor element for a flottform-root
  • Update default UI in demo (related task Implement new default UI on demo page #45) and multiple-input-form

@TamaraBogantseva
feat: update default ui
9347459 
Signed-off-by: TamaraBogantseva <[email protected]>
@TamaraBogantseva TamaraBogantseva added the 🤓 review needed Someone needs to review this PR label Aug 22, 2024
@TamaraBogantseva TamaraBogantseva force-pushed the feat/make-default-ui-customizable branch from c2abc38 to e7bcbc1 Compare August 26, 2024 13:19
Narigo
Narigo approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Narigo Narigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this API looks a lot better to use!

flottform/demo/src/routes/+page.svelte Outdated Show resolved Hide resolved
flottform/demo/src/routes/+page.svelte Outdated Show resolved Hide resolved
flottform/demo/src/routes/multiple-input-form/+page.svelte Outdated Show resolved Hide resolved
flottform/forms/src/flottform-text-input-host.ts Outdated Show resolved Hide resolved
flottform/forms/src/theme/flottform-default-component.ts Outdated Show resolved Hide resolved
flottform/forms/src/theme/flottform-default-component.ts Outdated Show resolved Hide resolved
flottform/forms/src/theme/flottform-default-component.ts Outdated Show resolved Hide resolved
flottform/forms/src/theme/flottform-default-component.ts Outdated Show resolved Hide resolved
flottform/demo/src/routes/+page.svelte Outdated Show resolved Hide resolved
@TamaraBogantseva TamaraBogantseva mentioned this pull request Sep 12, 2024
Closed
@TamaraBogantseva TamaraBogantseva mentioned this pull request Sep 12, 2024
Open
3 tasks
@TamaraBogantseva TamaraBogantseva force-pushed the feat/make-default-ui-customizable branch from 2d78bab to 8c77e59 Compare September 12, 2024 13:50
@Narigo
chore: Clean up unnecessary test files
83e2be2 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
fix: Emit a done message when file sending is completed
bebe72e 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
fix: Use logger instead of console for debug messages
370cdf1 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
chore: Remove roadmap as we moved it to gh project
1ad86a7 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
feat: Allow themes to be created inside of flottform/forms and only i…
efd60d7 
…mport the one relevant for the client

Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
chore: Remove server-standalone-old workspace
5e20e7a 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
chore: Move files and structure a bit
f74fddd 
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
fix: Allow onErrorText to be overridden and as a function
8e5abdc 
Signed-off-by: Joern Bernhardt <[email protected]>
nidhal-labidi
nidhal-labidi approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@nidhal-labidi nidhal-labidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this new way of doing things! We should merge it then update where-are-you.at to use this new version & update the docs accordingly

I added some comments/minor suggestions regarding where we define events

@nidhal-labidi nidhal-labidi merged commit 8628fbc into main Sep 24, 2024
@nidhal-labidi nidhal-labidi deleted the feat/make-default-ui-customizable branch September 24, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhal-labidi nidhal-labidi nidhal-labidi approved these changes

@Narigo Narigo Narigo approved these changes

Assignees
No one assigned
Labels
🤓 review needed Someone needs to review this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to set a label for the input field inside the popup
3 participants
@TamaraBogantseva @Narigo @nidhal-labidi