Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unchecked math in Comp token refresh #205

Open
z0r0z opened this issue Jun 14, 2022 · 0 comments
Open

use unchecked math in Comp token refresh #205

z0r0z opened this issue Jun 14, 2022 · 0 comments

Comments

@z0r0z
Copy link

z0r0z commented Jun 14, 2022

I noticed Comp token got a refresh and uses ^0.8.0 solidity. This will automatically do 'safemath' checks, which cost more gas. Since Comp token was already doing unchecked math in many cases, it makes sense to wrap these statements. For example this cannot underflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@z0r0z and others