Force validation for updating instructorship.instructor_id when merging ... #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,7 @@ def eat(victims) | |||
|
|
|||
| things.each do |thing| | |||
| puts " updating #{thing.inspect}" | |||
| raise "Failed update" unless thing.update_attribute(:instructor_id, self.id) | |||
| raise "Failed update" unless thing.update_attributes(:instructor_id => self.id) | |||
There was a problem hiding this comment.
#update_attributes! will raise an exception if validation fails, so you can just use that.
Also, unrelated to this change, but we really shouldn't be putting random print statements in the code like on line 59.
Other nitpick unrelated to this change: def eat(victims)? Really?
There was a problem hiding this comment.
I was quite amused by the usage of "things" as a variable name, made it really clear what I was looking at...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instructors
May partly or fully address https://hkn.eecs.berkeley.edu/redmine/issues/544