Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sp24 714 add test #91

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Sp24 714 add test #91

merged 2 commits into from
Aug 21, 2024

Conversation

ellenyuX
Copy link
Collaborator

Changes 💎

Short one-liner about the content

  • Describe the changes your pull request makes in short terms
    • If either of the topics here targets a specific issue, this should be referenced
  • You can use a list to describe multiple change
    • Use subpoints to describe smaller changes or details within the change

Notes 📖 ✏️

Write a few notes about the changes made if necessary.

Ivan-Computas
Ivan-Computas reviewed Aug 20, 2024
View reviewed changes
src/test/websocket_test.py
assert r2[0]["name"] == "joinGame"
assert r2[0]["args"][0]["game_id"] != r1[0]["args"][0]["game_id"]
assert r2[1]["args"][0]['ready'] == False

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that r1 didnt receive it neither ?

@Ivan-Computas Ivan-Computas merged commit adfc91f into develop Aug 21, 2024
1 check passed
@Ivan-Computas Ivan-Computas deleted the SP24_714_add_test branch August 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivan-Computas Ivan-Computas Ivan-Computas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellenyuX @Ivan-Computas