Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: be able to provision separate section(s) based on label(s) #17

Open
yarikoptic opened this issue Feb 17, 2023 · 3 comments

Comments

@yarikoptic
Copy link
Member

yarikoptic commented Feb 17, 2023

E.g.

custom_sections:
- name: Easy work needing help
  types: [pull, issue]
  labels: easy, contribution-desired

to create a section which would collate Pull requests and Issues which have both labels easy and contribution-desired.
It would then be useful to annotate/be able to find work which anyone in the team could pick up "when bored" or just to improve the greenness of their github profiles.

as for selection, I wonder if may be it could be generalized a little more exposing internal structure but making it also flexible

custom_sections:
- name: Easy work needing help
  condition: 'easy' in thing.labels and 'contribution-desired' in thing.labels"

where thing would be an issue (from self.active_issues) or a PR (from self.open_prs).

WDYT @jwodder ?

@jwodder
Copy link
Member

jwodder commented Feb 17, 2023

@yarikoptic I don't like the idea of running arbitrary Python code read from a config file.

@yarikoptic
Copy link
Member Author

A defense case: it is not "arbitrary" as cannot be provided by a possibly malicious "external" user. Here it is a part of the configuration file destined for execution by that user and if user can modify that file, he can as well modify the software directly or do that harm directly. We similarly expose for eval in datalad foreach-dataset and so far had no issue with that.

@yarikoptic
Copy link
Member Author

ultimately also would like to check if assigned or not already, so smth like

('easy' in thing.labels and 'contribution-desired' in thing.labels") and not thing.assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants