From 24962fa73923c55b046f23bd9a4d1f39c0e784c5 Mon Sep 17 00:00:00 2001 From: Martin Valgur Date: Thu, 2 Nov 2023 22:05:14 +0200 Subject: [PATCH] nss: disable MSVC Fails with ../../coreconf/rules.mk:164: *** multiple target patterns. Stop. make[2]: *** [../coreconf/rules.mk:44: bltest] Error 2 make[1]: *** [coreconf/rules.mk:44: cmd] Error 2 make: *** [manifest.mn:26: prepare_build] Error 2 And even the existing recipe fails with make[3]: *** No rule to make target '../certhigh/WINNT10.0-22621_x86_64_64_OPT.OBJ/certhtml.obj', needed by 'WINNT3.4.5.x86_64_x86_64_64_OPT.OBJ/nss3.dll'. Stop. on MSVC 193 for me. --- recipes/nss/all/conanfile.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/recipes/nss/all/conanfile.py b/recipes/nss/all/conanfile.py index d5ce4525d5f9f..e6c39f9d1407d 100644 --- a/recipes/nss/all/conanfile.py +++ b/recipes/nss/all/conanfile.py @@ -64,7 +64,10 @@ def validate(self): raise ConanInvalidConfiguration("Macos ARM64 builds not yet supported. Contributions are welcome.") if Version(self.version) < "3.74": if self.settings.compiler == "clang" and Version(self.settings.compiler.version) >= 13: - raise ConanInvalidConfiguration("nss < 3.74 requires clang < 13 .") + raise ConanInvalidConfiguration("nss < 3.74 requires clang < 13.") + if is_msvc(self): + # https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/19262/4-windows-visual_studio/nss/3.89/summary.json + raise ConanInvalidConfiguration("MSVC is currently not supported. Contributions are welcome.") def build_requirements(self): if self._settings_build.os == "Windows":