-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harfbuzz: add v8.5.0, v9.0.0, define components, drop vulnerable versions, add introspection support #25093
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your effort! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only a minor request, thanks!
if self.options.with_glib: | ||
self.tool_requires("glib/<host_version>") | ||
if self.options.get_safe("with_introspection"): | ||
self.tool_requires("gobject-introspection/1.78.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on gettings this recently fixed @uilianries @valgur :)
Thank you for your PR, I would ask a full build log using instropection option. Even switching to True in CCI and returning to False after having the build result. Providing a new option should be tested to avoid future issues. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Could someone (@uilianries @AbrilRBS) please regenerate the glib binaries to fix the CI test with The |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Summary
Changes to recipe: harfbuzz/[*]
Motivation
Needed for the GTK PR #25090.
harfbuzz-subset.pc
, which is currently missing.with_subset
option never had an effect. There is no corresponding option in the project and it does not introduce any dependencies.Details