Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harfbuzz: add v8.5.0, v9.0.0, define components, drop vulnerable versions, add introspection support #25093

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 31, 2024

Summary

Changes to recipe: harfbuzz/[*]

Motivation

Needed for the GTK PR #25090.

  • A newer version is required by the latest GTK 4.x.
  • GTK 4.x looks for harfbuzz-subset.pc, which is currently missing.
  • The with_subset option never had an effect. There is no corresponding option in the project and it does not introduce any dependencies.
  • Dropped vulnerable versions (<7.0) based on https://repology.org/project/harfbuzz/information.

Details


@valgur valgur changed the title harfbuzz: add v8.5.0, v9.0.0, define components, drop vulnerable versions harfbuzz: add v8.5.0, v9.0.0, define components, drop vulnerable versions, add introspection support Aug 31, 2024
@conan-center-bot

This comment has been minimized.

@ErniGH ErniGH assigned ErniGH and unassigned ErniGH Sep 2, 2024
recipes/harfbuzz/all/conanfile.py Outdated Show resolved Hide resolved
recipes/harfbuzz/all/conanfile.py Show resolved Hide resolved
ErniGH
ErniGH previously approved these changes Sep 3, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your effort! ❤️

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only a minor request, thanks!

recipes/harfbuzz/all/conanfile.py Outdated Show resolved Hide resolved
if self.options.with_glib:
self.tool_requires("glib/<host_version>")
if self.options.get_safe("with_introspection"):
self.tool_requires("gobject-introspection/1.78.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on gettings this recently fixed @uilianries @valgur :)

@uilianries
Copy link
Member

Thank you for your PR, I would ask a full build log using instropection option. Even switching to True in CCI and returning to False after having the build result. Providing a new option should be tested to avoid future issues.

@conan-center-bot

This comment has been minimized.

@valgur valgur mentioned this pull request Sep 6, 2024
3 tasks
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Sep 6, 2024
@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Sep 8, 2024

Could someone (@uilianries @AbrilRBS) please regenerate the glib binaries to fix the CI test with gobject-introspection enabled?

The glib binary was available just days ago and the recipe and not been updated. Does the hash of the required binary change each time a new version is matched by some version-range dependency or something like that?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 8 (27d32ebb3f13b869b25081f2bea31b1d49189011):

  • harfbuzz/9.0.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.1.1:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.3.0:
    CI failed to create some packages (All logs)

    Logs for packageID 0b0491bbdadd2c938abb0fd2ecd4cd7c861355e4:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    [options]
    harfbuzz:shared=True
    
    [...]
    pcre2/10.42: Package installed b359196ca5d3d5c89f5f661c25b5a6d70eb2c315
    pcre2/10.42: Downloaded package revision a941ce8d66421fee4021c493e51625c2
    freetype/2.13.2: Retrieving package f1014dc4f9380132c471ceb778980949abf136d3 from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    freetype/2.13.2: Package installed f1014dc4f9380132c471ceb778980949abf136d3
    freetype/2.13.2: Downloaded package revision 4987966bfbe255eff8cf29067fa2fa0b
    libselinux/3.6: Retrieving package 6b0384e3aaa343ede5d2bd125e37a0198206de42 from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    libselinux/3.6: Package installed 6b0384e3aaa343ede5d2bd125e37a0198206de42
    libselinux/3.6: Downloaded package revision a257a4ae13d6c4b978767bfabd759c36
    glib/2.78.3: Retrieving package 478ad8f1749150b1e40b726fdf1528d9ddd9ec8e from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    glib/2.78.3: Package installed 478ad8f1749150b1e40b726fdf1528d9ddd9ec8e
    glib/2.78.3: Downloaded package revision f0c7ef8f4652f3ba6cf888e02073d67b
    gobject-introspection/1.78.1: Retrieving package 798ea126aa6659bb6fb61add8f6866b25373b00a from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    gobject-introspection/1.78.1: Package installed 798ea126aa6659bb6fb61add8f6866b25373b00a
    gobject-introspection/1.78.1: Downloaded package revision d5d2c0e446978c7ba6e979e7ce08d363
    pcre2/10.42: Appending PATH environment variable: /home/conan/workspace/prod-v1/bsr/103008/adeda/.conan/data/pcre2/10.42/_/_/package/b359196ca5d3d5c89f5f661c25b5a6d70eb2c315/bin
    harfbuzz/8.3.0: Applying build-requirement: meson/1.5.1
    harfbuzz/8.3.0: Applying build-requirement: pkgconf/2.2.0
    harfbuzz/8.3.0: Applying build-requirement: gobject-introspection/1.78.1
    harfbuzz/8.3.0: Applying build-requirement: ninja/1.12.1
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    harfbuzz/8.3.0: Configuring sources in /home/conan/workspace/prod-v1/bsr/103008/adeda/.conan/data/harfbuzz/8.3.0/_/_/source/src
    harfbuzz/8.3.0: 
    [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
    [HOOK - conan-center.py] post_source(): [CPPSTD MANAGEMENT (KB-H022)] OK
    [HOOK - conan-center.py] post_source(): [SHORT_PATHS USAGE (KB-H066)] OK
    harfbuzz/8.3.0: Copying sources to build folder
    harfbuzz/8.3.0: Building your package in /home/conan/workspace/prod-v1/bsr/103008/adeda/.conan/data/harfbuzz/8.3.0/_/_/build/0b0491bbdadd2c938abb0fd2ecd4cd7c861355e4
    harfbuzz/8.3.0: Generator txt created conanbuildinfo.txt
    harfbuzz/8.3.0: Calling generate()
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    WARN: libpng/1.6.44: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3.1 
    WARN: pcre2/10.42: requirement zlib/[>=1.2.11 <2] overridden by glib/2.78.3 to zlib/1.3.1 
    ERROR: harfbuzz/8.3.0: Error in generate() method, line 156
    	deps.generate()
    	ConanException: The 'build_context_activated' and 'build_context_build_modules' of the PkgConfigDeps generator cannot be used without specifying a build profile. e.g: -pr:b=default
    
  • harfbuzz/8.2.1:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.5.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.2.2:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.0.1:
    Didn't run or was cancelled before finishing

  • harfbuzz/7.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 8 (27d32ebb3f13b869b25081f2bea31b1d49189011):

  • harfbuzz/8.5.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.2.1:
    Didn't run or was cancelled before finishing

  • harfbuzz/9.0.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.0.1:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.2.2:
    CI failed to create some packages (All logs)

    Logs for packageID a0328132a98a82c49ca92e7ed3953ca4d33c28cc:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
        brotli/1.1.0#d56d7bb9ca722942aba17369cb5c0519:31b216f5bb11630e2c0601548f2a3d71f2558be9#43c8a9b3a8dc427d2dbcb60497cddf19 - Download (conan-center)
        bzip2/1.0.8#d00dac990f08d991998d624be81a9526:582795513620c02434315fe471662206b3a90c44#32df64d7ab9f75d4f9d87c427788ca9c - Download (conan-center)
        freetype/2.13.2#7934d59c447d72edcd56025dc60e1aeb:9278f7ec43a6ecbe20123191128f92bc7a2d1cc8#5225463255a2fe163cbd40a428d6bc6a - Download (conan-center)
        glib/2.78.3#0d214f34a22088571a43892d3fd41093:0733c09591034edf59f9cb68ba0b1c0fa8a114cd#73603dee2c1ce08f567d575a948b5239 - Download (conan-center)
        harfbuzz/8.2.2#0115c54ce23697f80c1684658ef5a1c7:a0328132a98a82c49ca92e7ed3953ca4d33c28cc - Build
        libelf/0.8.13#4f70a3555809ae50cc8add44f0f84288:abe5e2b04ea92ce2ee91bc9834317dbe66628206#4132a17033da50fd053b37f478c5cbfa - Download (conan-center)
        libffi/3.4.4#72cccac6139293b6e97ec9cd676547ff:abe5e2b04ea92ce2ee91bc9834317dbe66628206#1eb27db6bb43bc330647d2995d5ab1db - Download (conan-center)
        libmount/2.39#8a95198b2547a8ca7685eb7a1d002903:abe5e2b04ea92ce2ee91bc9834317dbe66628206#a49d4b464a6680ee57ca160a4d56c571 - Download (conan-center)
        libpng/1.6.44#9e1aa08fb46946c7c91e4ae03bd49811:84ae3df57199b67cf54d99de695e2f68bbb208a8#fb4ce153125e07bca95b70149b613cbd - Download (conan-center)
        libselinux/3.6#5a78ff6ae5034eeaac8da723361a8ce4:4f2156f1ce77698b233462b32aa0bf16ece347bf#f90e44584f07478174efcbc74fa08d6e - Download (conan-center)
        pcre2/10.42#576680686b88a4dadf6d382d6d6351d9:658ab2f12634da05c0e8fd2b2864020391bcdd66#f057bb6f125ad3ddd7c06224f77332ae - Download (conan-center)
        zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:abe5e2b04ea92ce2ee91bc9834317dbe66628206#27ae0ca7f3a05ab175379dcf83fd640b - Download (conan-center)
    Build requirements
        glib/2.78.3#0d214f34a22088571a43892d3fd41093:145c20b342441ad064f8512bb9cfd4edc511dfc0 - Missing
        gobject-introspection/1.78.1#56af6d1e46e8d0fae063874c2a0ac1fc:57a56314b3a9d24019dbef422ea5293b42a95ead - Missing
        meson/1.3.2#26ce8a76a36cc275cdfee1d757bc6561:da39a3ee5e6b4b0d3255bfef95601890afd80709#3ba677cf44c95996f4f326c668f92f00 - Download (conan-center)
        ninja/1.12.1#fd583651bf0c6a901943495d49878803:3593751651824fb813502c69c971267624ced41a#a46e32b2b79add597b73d8b42c415ed1 - Download (conan-center)
        pkgconf/2.2.0#6462942a22803086372db44689ba825f:c0b621fd4b3199fe05075171573398833dba85f4#35e5163b1cf42becef616e6b7873202e - Download (conan-center)
    Skipped binaries
        autoconf/2.71, bison/3.8.2, bzip2/1.0.8, flex/2.6.4, glib/2.78.3, gnu-config/cci.20210814, libelf/0.8.13, libffi/3.4.4, libmount/2.39, libselinux/3.6, m4/1.4.19, meson/1.2.2, pcre2/10.42, pkgconf/2.0.3, pkgconf/2.1.0, zlib/1.3.1
    ERROR: Missing binary: glib/2.78.3:145c20b342441ad064f8512bb9cfd4edc511dfc0
    ERROR: Missing binary: gobject-introspection/1.78.1:57a56314b3a9d24019dbef422ea5293b42a95ead
    
    glib/2.78.3: WARN: Can't find a 'glib/2.78.3' package binary '145c20b342441ad064f8512bb9cfd4edc511dfc0' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.version=11
    os=Linux
    [options]
    shared=True
    with_elf=True
    with_mount=True
    with_selinux=True
    [requires]
    bzip2/1.0.8#d00dac990f08d991998d624be81a9526:763ddd53d7a4775fe84a285f56005a096d9786fd
    libelf/0.8.13#4f70a3555809ae50cc8add44f0f84288:b647c43bfefae3f830561ca202b6cfd935b56205
    libffi/3.4.4#72cccac6139293b6e97ec9cd676547ff:b647c43bfefae3f830561ca202b6cfd935b56205
    libmount/2.39#8a95198b2547a8ca7685eb7a1d002903:b647c43bfefae3f830561ca202b6cfd935b56205
    libselinux/3.6#5a78ff6ae5034eeaac8da723361a8ce4:da733d2d67127a5743fb5f2fa5f8859f298107b1
    pcre2/10.42#576680686b88a4dadf6d382d6d6351d9:3ad2a8f0588fa84c2c7e638193c099d49b433df1
    zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:b647c43bfefae3f830561ca202b6cfd935b56205
    
    ERROR: Missing prebuilt package for 'glib/2.78.3', 'gobject-introspection/1.78.1'. You can try:
        - List all available packages using 'conan list "glib/2.78.3:*" -r=remote'
        - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
        - Try to build locally from sources using the '--build=glib/2.78.3 --build=gobject-introspection/1.78.1' argument
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • harfbuzz/8.3.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/7.3.0:
    Didn't run or was cancelled before finishing

  • harfbuzz/8.1.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants