-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtiff: bump deps & use version range for xz_utils & zstd #25208
Conversation
🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member. |
This PR results in future conflicts, the
In case adopting this PR, by building libtiff with those new dependencies, we will have those conflicts later: Using the profile Linux GCC-11 Release static only (same as in CCI):
|
@AbrilRBS Could you please explain the problem? Why was this closed? Is it possible to use zstd/1.5.6 with libtiff? Is that too difficult? It looks like it breaks many if not all dependers of libtiff? Is this a conan-specific problem or is it related to these projects explicitly requiring zstd/1.5.5? Is there any upgrade path? Would it be possible to do this change for the next libtiff release for example without touching the older libtiff versions? |
Hello @stevn! This PR is not adding a new version, neither fixing a registered bug in issues. Are experience an error, like missing package or version conflicts? The PR was closed due the massive dependencies graph affected by libtiff, as I commented previously. It can be updated yes, but need extra effort as the CI need follow a specific build order to avoid conflicts and missing binaries. This kind of operation is reversed for more important events, like security failure in a version, or a new version that affects many packages. To mitigate such situation, CCI is adopting version ranges, but not all package are using it yet, as the team need to check each package for compatibility. There is a documentation about what package are supported with version ranges in CCI so far: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/dependencies.md#adherence-to-build-service
When update libtiff version we could take the opportunity not only to re-visit the case, but also using more version ranges in CCI. |
@uilianries Wouldn't adding the version ranges for self.requires("xz_utils/[>=5.4.5 <6]")
self.requires("zstd/[>=1.5 <1.6]") be justified to avoid conflicts in other libraries? I would keep the rest as is. |
@uilianries Thanks for the quick reply! This is valuable information that lets me understand the implications of such a change. I really appreciate your effort in examining such version dependencies, conflicts etc. I have created a test project here which demonstrates my problem: https://github.com/stevn/conan_test_tiff Since the libtiff v4.7.0 conan package hardcodes its requirement to zstd v1.5.5, I tried using I also read this note in the Conan documentation pages:
See https://docs.conan.io/2.0/reference/conanfile/methods/requirements.html So I am currently not sure how to proceed. |
Yes, but the reason we're not allowing them either right now is to avoid the proliferation of PRs that just add this change which would collapse our ability to focus on more important PRs and the rest of the current backlog. As the new CI pipeline is quite close, we prefer to keep the pain for a bit more, and then once we can open 1 PR with all the changes, bring all the recipes that need version ranges up-to-date with eachother. I hope this helps to understand the situation a bit better :) |
This is because the But the best approach currently in Conan 2 to temporaly solve conflicts and try new versions graph-wise which have no control over, is to use the I hope this helps, if you have any other question feel free to open an issue either here if its recipe-specific, or in the main Conan repo, we're always happy to help :) |
Oh, I see. Sorry, my mistake. I updated the test project to use
I'll give that a try as well, thanks! |
Summary
Changes to recipe: libtiff/all
Motivation
Use version range for xz_utils & zstd dependencies since it's now allowed, and bump some other deps in the meantime.
closes #25206
Details