Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curlpp: add recipe #25244

Merged
merged 10 commits into from
Oct 17, 2024
Merged

curlpp: add recipe #25244

merged 10 commits into from
Oct 17, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 12, 2024

Summary

Changes to recipe: curlpp/0.8.1.cci.20240530

Motivation

curlpp is required by minio-cpp.
I want to add minio-cpp to cci.

Details

https://github.com/jpbarrette/curlpp

@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments, looks good otherwise :)

recipes/curlpp/all/conanfile.py Outdated
cmake_layout(self, src_folder="src")

def requirements(self):
self.requires("libcurl/8.9.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curlpp/cURLpp.hpp includes curl.h, so this needs to be transitive too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
Thank a lot!

recipes/curlpp/all/conanfile.py Show resolved Hide resolved
@AbrilRBS AbrilRBS self-assigned this Sep 12, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :)

perseoGI
perseoGI previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

Sign in to view
@toge toge dismissed stale reviews from perseoGI and AbrilRBS via 328491e September 23, 2024 07:18
@valgur
Copy link
Contributor

valgur commented Sep 23, 2024

@toge The CMP0091 error is typically caused by cmake_minimum_required() being called after project() in the main CMakeLists.txt. That seems to be case in curlpp as well. You'll probably need to patch the CMakeLists.txt.

@toge
Copy link
Contributor Author

toge commented Sep 23, 2024

@valgur
Thank you!
I will fix soon!

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 10 (c13a3624b99119b2b348fddc04bfa5df5fbb5aae):

  • curlpp/0.8.1.cci.20240530:
    Built 16 packages out of 22 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (c13a3624b99119b2b348fddc04bfa5df5fbb5aae):

  • curlpp/0.8.1.cci.20240530:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit c13a362
curlpp/0.8.1.cci.20240530@#fd7813a80c4c136d133c05f5d8cddc22 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcurlpp.so' links to system library 'm' but it is not in cpp_info.system_libs.

AbrilRBS
AbrilRBS approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbrilRBS AbrilRBS requested a review from perseoGI October 10, 2024 18:41
ErniGH
ErniGH approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 420dedf into conan-io:master Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErniGH ErniGH ErniGH approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@perseoGI perseoGI Awaiting requested review from perseoGI

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @valgur @AbrilRBS @perseoGI @ErniGH