Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libarchive: add version 3.7.6 #25333

Merged
merged 2 commits into from
Sep 23, 2024
Merged

libarchive: add version 3.7.6 #25333

merged 2 commits into from
Sep 23, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 19, 2024 •
edited
Loading

Summary

Changes to recipe: libarchive/3.7.6

Motivation

There are several bugfixes and security fixes in 3.7.6.

Details

libarchive/libarchive@v3.7.4...v3.7.6

@conan-center-bot

This comment has been minimized.

Sign in to view
ErniGH
ErniGH reviewed Sep 20, 2024
View reviewed changes
recipes/libarchive/all/patches/0003-3.7.5-cmake.patch Outdated
Comment on lines 18 to 20
- INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
+ LIST(APPEND ADDITIONAL_LIBS ZLIB::ZLIB)
LIST(APPEND ADDITIONAL_LIBS ${ZLIB_LIBRARIES})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous patch was like

Suggested change
- INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
+ LIST(APPEND ADDITIONAL_LIBS ZLIB::ZLIB)
LIST(APPEND ADDITIONAL_LIBS ${ZLIB_LIBRARIES})
INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
- LIST(APPEND ADDITIONAL_LIBS ${ZLIB_LIBRARIES})
+ LIST(APPEND ADDITIONAL_LIBS ZLIB::ZLIB)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErniGH
Thank you for your pointing out!
I fixed this.

@toge toge changed the title libarchive: add version 3.7.5 libarchive: add version 3.7.6 Sep 23, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (83c6b51d49e5bc9ddd5768c51d8d2882de90f66b):

  • libarchive/3.7.4:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.3:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.2:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.6:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.1:
    Built 20 packages out of 22 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (83c6b51d49e5bc9ddd5768c51d8d2882de90f66b):

  • libarchive/3.7.3:
    All packages built successfully! (All logs)

  • libarchive/3.7.1:
    All packages built successfully! (All logs)

  • libarchive/3.7.4:
    All packages built successfully! (All logs)

  • libarchive/3.7.2:
    All packages built successfully! (All logs)

  • libarchive/3.7.6:
    All packages built successfully! (All logs)

ErniGH
ErniGH approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! 😄

@ErniGH ErniGH requested a review from AbrilRBS September 23, 2024 14:17
@AbrilRBS AbrilRBS self-assigned this Sep 23, 2024
@conan-center-bot conan-center-bot merged commit aed0fd7 into conan-io:master Sep 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErniGH ErniGH ErniGH approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @AbrilRBS @ErniGH