Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan-center] KB-H040 recommendation is outdated #387

Open
SSE4 opened this issue Feb 21, 2022 · 4 comments
Open

[conan-center] KB-H040 recommendation is outdated #387

SSE4 opened this issue Feb 21, 2022 · 4 comments
Assignees

Comments

@SSE4
Copy link
Contributor

SSE4 commented Feb 21, 2022

from conan-io/conan-center-index#9409

[HOOK - conan-center.py] pre_export(): ERROR: [NO TARGET NAME (KB-H040)] CCI uses the name of the package for cmake generator. Use 'cpp_info.names' instead. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H040) 

the recommendation to use cpp_info.names looks a bit outdated, I believe, going forward, set_properties should be recommended

@SSE4 SSE4 changed the title [conan-center] KB-H040 [conan-center] KB-H040 recommendation is outdated Feb 21, 2022
@uilianries
Copy link
Member

Related to conan-io/docs#2429

Indeed it will be deprecated at Conan 2.0, but is still relevant don't?

We could add more information about set_property, but cpp_info.names is still used.

@uilianries
Copy link
Member

I want to think about something more audacious: A hook which check not only set_properties, but Conan V2: https://docs.conan.io/en/latest/conan_v2.html

The advantage is that we no longer need to create more and more hooks, we can englobe all checks in a single hook. A migration hook, not ConanV2 hook.

In the future, we can create new hooks related to Conan 2.0 when it become the default version.

@SSE4
Copy link
Contributor Author

SSE4 commented Mar 4, 2022

I suppose it should be a part of conan-io/conan#10607

@uilianries
Copy link
Member

That's it! A linter would be perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants