-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubot Update #251
Comments
I'll add this to here:
|
What hubot script caused this error? I've seen it before but haven't had time to investigate. The majority of hubot scripts should at least load, even if they don't function fully. |
I can't really tell, I tried disabling them all and enabling one by one using kpm to quickly test now, but none gave the error during loading, but |
Interesting, that would be a regression if kpm was saying that something loaded when it didn't. Note that if you are copying modules across to the latest clone, ensure modules like kpm are up-to-date first. As much as I tried to ensure there were not many breaking changes some backwards incompatibilities in #270 were unavoidable. As a side note, now that loading is async we need to add a way to work out which loading succeeded/failed message belongs with which module. |
Since initial hubot support was implemented, many features such as middleware have been introduced in Concierge. The equivilant features have sub-optimal implementations within the hubot loader which could be replaced with their new Concierge counterparts.
The text was updated successfully, but these errors were encountered: