Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-aarch64 and osx-arm64 #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

parham-k
Copy link

@parham-k parham-k commented Nov 20, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 20, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@parham-k
Copy link
Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits November 20, 2024 19:07
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@parham-k
Copy link
Author

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated
@@ -36,3 +36,6 @@ extra:
- SylvainCorlay
- wolfv
- marimeireles
additional-platforms:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this works here.
The additional-platforms thingy is the BioConda way. The Conda-forge way is https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6726/files and https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6726/files

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore! I was commenting on old code.

@martin-g martin-g mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants