Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sys.exit from noarch_python and add unittests #5425

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

kenodegard
Copy link
Contributor

Description

While working on #5255 found an opportunity to add unittests and do a small refactor to conda_build.noarch_python.rewrite_script.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner July 25, 2024 20:36
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 25, 2024
beckermr
beckermr previously approved these changes Jul 25, 2024
Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #5425 will not alter performance

Comparing kenodegard:rewrite_script (2f3f3f8) with main (d908fe1)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard merged commit 88b1995 into conda:main Aug 6, 2024
28 checks passed
@kenodegard kenodegard deleted the rewrite_script branch August 6, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants