Merge pull request #6 from Young-Zen/fix-typo-in-WorkflowTaskTypeCons…

…traint Fix typo in WorkflowTaskTypeConstraint
conductor-oss · Dec 17, 2023 · a207798 · a207798
2 parents c1bf109 + 4762cc2
commit a207798
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/core/src/main/java/com/netflix/conductor/validations/WorkflowTaskTypeConstraint.java b/core/src/main/java/com/netflix/conductor/validations/WorkflowTaskTypeConstraint.java
@@ -262,7 +262,7 @@ private boolean isDoWhileTaskValid(
                 String message =
                         String.format(
                                 PARAM_REQUIRED_STRING_FORMAT,
-                                "loopExpression",
+                                "loopCondition",
                                 TaskType.DO_WHILE,
                                 workflowTask.getName());
                 context.buildConstraintViolationWithTemplate(message).addConstraintViolation();
@@ -272,7 +272,7 @@ private boolean isDoWhileTaskValid(
                 String message =
                         String.format(
                                 PARAM_REQUIRED_STRING_FORMAT,
-                                "loopover",
+                                "loopOver",
                                 TaskType.DO_WHILE,
                                 workflowTask.getName());
                 context.buildConstraintViolationWithTemplate(message).addConstraintViolation();

diff --git a/core/src/test/java/com/netflix/conductor/validations/WorkflowTaskTypeConstraintTest.java b/core/src/test/java/com/netflix/conductor/validations/WorkflowTaskTypeConstraintTest.java
@@ -170,10 +170,10 @@ public void testWorkflowTaskTypeDoWhile() {
 
         assertTrue(
                 validationErrors.contains(
-                        "loopExpression field is required for taskType: DO_WHILE taskName: encode"));
+                        "loopCondition field is required for taskType: DO_WHILE taskName: encode"));
         assertTrue(
                 validationErrors.contains(
-                        "loopover field is required for taskType: DO_WHILE taskName: encode"));
+                        "loopOver field is required for taskType: DO_WHILE taskName: encode"));
     }
 
     @Test