Handle multiple set-cookie headers from fetch API Headers object (#746)

connectrpc · Aug 8, 2023 · 8f48d77 · 8f48d77
1 parent e6cd6a1
commit 8f48d77
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/packages/connect-node/src/node-universal-header.ts b/packages/connect-node/src/node-universal-header.ts
@@ -71,22 +71,30 @@ export function webHeaderToNodeHeaders(
     return undefined;
   }
   const o = Object.create(null) as http.OutgoingHttpHeaders;
+  const append = (key: string, value: string): void => {
+    key = key.toLowerCase();
+    const existing = o[key];
+    if (typeof existing == "string") {
+      o[key] = [existing, value];
+    } else if (Array.isArray(existing)) {
+      existing.push(value);
+    } else {
+      o[key] = value;
+    }
+  };
   if (Array.isArray(headersInit)) {
     for (const [key, value] of headersInit) {
-      const k = key.toLowerCase();
-      o[k] = value;
+      append(key, value);
     }
   } else if ("forEach" in headersInit) {
     if (typeof headersInit.forEach == "function") {
       headersInit.forEach((value, key) => {
-        const k = key.toLowerCase();
-        o[k] = value;
+        append(key, value);
       });
     }
   } else {
     for (const [key, value] of Object.entries<string>(headersInit)) {
-      const k = key.toLowerCase();
-      o[k] = value;
+      append(key, value);
     }
   }
   return o;