Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration cli #769

Merged
merged 31 commits into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4431092
wip
paul-sachs Aug 15, 2023
5433b6f
Basic operations working
paul-sachs Aug 15, 2023
9063624
Remove unused dep an move some files
paul-sachs Aug 15, 2023
bf75a0e
Remove test files from includes
paul-sachs Aug 15, 2023
dd2c205
Fix lint
paul-sachs Aug 15, 2023
fc9c18f
Reorg
paul-sachs Aug 16, 2023
384f2fa
Some review comments
paul-sachs Aug 16, 2023
ec75584
Removed tsup and reorganized bin files
paul-sachs Aug 16, 2023
ef76f08
Updated to run jscodeshift directly
paul-sachs Aug 16, 2023
192d971
Remove jest dependency
paul-sachs Aug 16, 2023
79e0b95
Fix up test fixtures
paul-sachs Aug 16, 2023
e384964
Added rename and remove unused cli argument
paul-sachs Aug 16, 2023
d90b6f1
Update readme
paul-sachs Aug 16, 2023
92162a3
Merge branch 'main' into psachs/migrate
paul-sachs Aug 16, 2023
61169f6
Update logic to detect failed install
paul-sachs Aug 16, 2023
54b8de5
Remove dynamic RegExp
paul-sachs Aug 16, 2023
bf40881
Use explicit check
paul-sachs Aug 16, 2023
0f307e3
Add connect-migrate to makefile
paul-sachs Aug 16, 2023
b225da7
Add clean stage to match protoc
paul-sachs Aug 16, 2023
b8c62d2
Fix formatting
paul-sachs Aug 16, 2023
11cac21
Update packages/connect-migrate/tsconfig.json
paul-sachs Aug 17, 2023
15b3343
Update packages/connect-migrate/package.json
paul-sachs Aug 17, 2023
fa9ea39
Update packages/connect-migrate/package.json
paul-sachs Aug 17, 2023
36f1f31
Update packages/connect-migrate/src/transforms/modify-imports.spec.ts
paul-sachs Aug 17, 2023
1885604
Add recursive, ignore-pattern, and no-install flags
paul-sachs Aug 17, 2023
7103a8a
Fix quote style in migration CLI (#774)
timostamm Aug 17, 2023
31aa30a
Use different parsers for different file endings
paul-sachs Aug 17, 2023
1b6c7ae
updated lock file
paul-sachs Aug 17, 2023
d85e5a2
Fix lint
paul-sachs Aug 17, 2023
be1e688
Improve DX with migration CLI (#776)
timostamm Aug 18, 2023
85fe4ec
Merge branch 'main' into psachs/migrate
timostamm Aug 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ $(BUILD)/example: $(GEN)/example $(BUILD)/connect-web packages/example/tsconfig.
@mkdir -p $(@D)
@touch $(@)

$(BUILD)/connect-migrate: packages/connect-migrate/package.json packages/connect-migrate/tsconfig.json $(shell find packages/connect-migrate/src -name '*.ts')
npm run -w packages/connect-migrate clean
npm run -w packages/connect-migrate build
@mkdir -p $(@D)
@touch $(@)

$(GEN)/connect: node_modules/.bin/protoc-gen-es packages/connect/buf.gen.yaml $(shell find packages/connect/src -name '*.proto') Makefile
rm -rf packages/connect/src/gen/*
npm run -w packages/connect generate
Expand Down Expand Up @@ -161,10 +167,10 @@ clean: crosstestserverstop ## Delete build artifacts and installed dependencies
git clean -Xdf

.PHONY: build
build: $(BUILD)/connect $(BUILD)/connect-web $(BUILD)/connect-node $(BUILD)/connect-fastify $(BUILD)/connect-express $(BUILD)/connect-next $(BUILD)/protoc-gen-connect-es $(BUILD)/example ## Build
build: $(BUILD)/connect $(BUILD)/connect-web $(BUILD)/connect-node $(BUILD)/connect-fastify $(BUILD)/connect-express $(BUILD)/connect-next $(BUILD)/protoc-gen-connect-es $(BUILD)/example $(BUILD)/connect-migrate ## Build

.PHONY: test
test: testconnectpackage testconnectnodepackage testnode testwebnode testwebbrowser ## Run all tests, except browserstack
test: testconnectpackage testconnectnodepackage testnode testwebnode testwebbrowser testconnectmigrate ## Run all tests, except browserstack

.PHONY: testconnectpackage
testconnectpackage: $(BUILD)/connect
Expand Down Expand Up @@ -214,6 +220,10 @@ testwebbrowserlocal: $(BUILD)/connect-web-test
testwebbrowserstack: $(BUILD)/connect-web-test
npm run -w packages/connect-web-test karma-browserstack

.PHONY: testconnectmigrate
testconnectmigrate: $(BUILD)/connect-migrate
npm run -w packages/connect-migrate test

.PHONY: lint
lint: node_modules $(BUILD)/connect-web $(GEN)/connect-web-bench ## Lint all files
npx eslint --max-warnings 0 .
Expand Down
Loading